Red Hat Bugzilla – Bug 165892
Review Request: xsupplicant
Last modified: 2007-11-30 17:11:11 EST
Spec Name or Url: http://www.auroralinux.org/people/spot/review/xsupplicant.spec
SRPM Name or Url: http://www.auroralinux.org/people/spot/review/xsupplicant-1.2-0.1.pre1.src.rpm
This software allows a GNU/Linux or BSD workstation to authenticate with
a RADIUS server using 802.1x and various EAP protocols. The intended
use is for computers with wireless LAN connections to complete a strong
authentication before joining the network.
I have followed the link to sourceforge and I only find the the 1.2 version.
If you redo the package for 1.2 I will review the package.
FWIW, the spec file looks perfect. :-)
Sneaky, sneaky. They haven't updated their website yet. :)
New SRPM: http://www.auroralinux.org/people/spot/review/xsupplicant-1.2-1.src.rpm
New SPEC: http://www.auroralinux.org/people/spot/review/xsupplicant.spec
+ package builds in mock for x86_64
+ rpmlint check
E: xsupplicant non-readable /etc/xsupplicant.conf 0600
(clearly here rpmlint is wrong, xsupplicant configuration should not be
+ package follows name convention and the spec file is correctly named
+ no locales, libraries, subpackages, pkgconfigs etc. to worry about
+ not relocatable
+ no directory ownership or permissions issues
+ no duplicate files
+ the license is correct (GPL) and it ships in the package
+ the spec file is in English and it is readable
+ the source file is the same as upstream (sha1sum agrees)
+ build requires are correct (*)
So the package is APPROVED.
(*) Is the any special reason to require byacc and not bison? I am just
No reason. In fact, I'll change it to bison before I commit.
Reopening bug to fix assignee.
Assignee fixed, closing again.