Bug 165903 - Review Request: perl-Carp-Assert - Executable comments
Summary: Review Request: perl-Carp-Assert - Executable comments
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ralf Corsepius
QA Contact: David Lawrence
URL: http://search.cpan.org/dist/Carp-Assert/
Whiteboard:
Keywords:
Depends On:
Blocks: FE-ACCEPT 165904
TreeView+ depends on / blocked
 
Reported: 2005-08-13 20:46 UTC by Jose Pedro Oliveira
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

(edit)
Clone Of:
(edit)
Last Closed: 2005-08-26 13:15:15 UTC


Attachments (Terms of Use)

Description Jose Pedro Oliveira 2005-08-13 20:46:09 UTC
Spec Name or Url:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-Carp-Assert.spec
SRPM Name or Url:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-Carp-Assert-0.18-1.src.rpm

Description:
Carp::Assert is intended for a purpose like the ANSI C library assert.h.

Comment 1 Ralf Corsepius 2005-08-22 12:39:06 UTC
NEEDSWORK:

The package builds fine in chroot without Test::Inline installed, but chokes if
Test::Inline is installed:

rpmbuild ...
...
cp lib/Carp/Assert.pm blib/lib/Carp/Assert.pm
make: pod2test: Command not found
...

Nitpicking:
- %check || :

Comment 2 Paul Howarth 2005-08-22 12:57:19 UTC
(In reply to comment #1)
> NEEDSWORK:
> 
> The package builds fine in chroot without Test::Inline installed, but chokes if
> Test::Inline is installed:
> 
> rpmbuild ...
> ...
> cp lib/Carp/Assert.pm blib/lib/Carp/Assert.pm
> make: pod2test: Command not found
> ...

The Changes file for Test::Inline says that pod2test was removed at version
2.00_07. This probably needs fixing upstream.


Comment 3 Ralf Corsepius 2005-08-22 14:48:16 UTC
(In reply to comment #2)
I think adding a
BuildConflicts: perl(Test::Inline) >= 2.00_07

or even more restrictive
BuildConflicts: perl(Test::Inline)

would be sufficient to prevent this issue.

Comment 4 Jose Pedro Oliveira 2005-08-25 19:51:04 UTC
Added the more restrictive build conflict. Tomorrow will take this upstream
(rt.cpan.org).

New signed SRPM:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-Carp-Assert-0.18-2.src.rpm

Comment 5 Ralf Corsepius 2005-08-26 11:11:27 UTC
perfect - APPROVED

Comment 6 Jose Pedro Oliveira 2005-08-26 13:15:15 UTC
Build completed for targets FC-3, FC-4, and devel.



Note You need to log in before you can comment on or make changes to this bug.