Spec URL: https://bunnyapocalypse.space/cog.spec SRPM URL: https://bunnyapocalypse.space/cog-0.2.0-1.fc29.src.rpm Description: Cog is a small single “window” launcher for the WebKit WPE port. It is small, provides no user interface, and is suitable to be used as a Web application container. This is the first useful frontend for WPE, and will be very useful for embedded kiosk type projects that just need to display a webpage. Fedora Account System Username:bunnyapocalypse Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=31450685
- The Version-Release info in the changelog entry is wrong: * Thu Dec 6 2018 Chris King <bunnyapocalypse> - 0.2.0-1 - The Source0 URL is 404, I think it should be: Source0: http://github.com/igalia/cog/releases/download/v%{version}/%{name}-%{version}.tar.xz - Remove the dot at the end of the Summary and remove the double "A a" at the start: Summary: A small single “window” launcher for the WebKit WPE port - Split the description to stay under 80 characters per line: %description Cog is a small single “window” launcher for the WebKit WPE port. It is small, provides no user interface, and is suitable to be used as a Web application container. The “window” may be fullscreen depending on the WPE backend being used. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Expat License", "Unknown or generated". 33 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/cog/review-cog/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in cog- debuginfo , cog-debugsource [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: cog-0.2.0-1.fc30.x86_64.rpm cog-devel-0.2.0-1.fc30.x86_64.rpm cog-debuginfo-0.2.0-1.fc30.x86_64.rpm cog-debugsource-0.2.0-1.fc30.x86_64.rpm cog-0.2.0-1.fc30.src.rpm cog.x86_64: W: summary-ended-with-dot C A a small single “window” launcher for the WebKit WPE port. cog.x86_64: W: spelling-error %description -l en_US fullscreen -> full screen, full-screen, firescreen cog.x86_64: E: description-line-too-long C Cog is a small single “window” launcher for the WebKit WPE port. It is small, provides no user interface, and is suitable to be used as a Web application container. The “window” may be fullscreen depending on the WPE backend being used. cog.x86_64: W: incoherent-version-in-changelog 2.21.92-2 ['0.2.0-1.fc30', '0.2.0-1'] cog.x86_64: W: shared-lib-calls-exit /usr/lib64/libcogcore.so.0.1.0 exit.5 cog.x86_64: W: no-soname /usr/lib64/libcogplatform-fdo.so cog.x86_64: W: no-documentation cog.x86_64: W: no-manual-page-for-binary cog cog.x86_64: W: no-manual-page-for-binary cogctl cog-devel.x86_64: W: no-documentation cog.src: W: summary-ended-with-dot C A a small single “window” launcher for the WebKit WPE port. cog.src: W: spelling-error %description -l en_US fullscreen -> full screen, full-screen, firescreen cog.src: E: description-line-too-long C Cog is a small single “window” launcher for the WebKit WPE port. It is small, provides no user interface, and is suitable to be used as a Web application container. The “window” may be fullscreen depending on the WPE backend being used. 5 packages and 0 specfiles checked; 2 errors, 11 warnings.
Thanks for the review again zebob! I have fixed what you mentioned.
I don't see the fixes? - The Source0 URL is 404, I think it should be: Source0: http://github.com/igalia/cog/releases/download/v%{version}/%{name}-%{version}.tar.xz - Remove the double "A a" at the start: Summary: A small single “window” launcher for the WebKit WPE port
Sorry it has taken me so long to get back to this. I have made the requested changes, and also updated for the new version of Cog. Here's a new spec: https://bunnyapocalypse.space/cog.spec And here's a new SRPM: https://bunnyapocalypse.space/cog-0.3.0-1.fc29.src.rpm
Package approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/cog
cog-0.3.0-1.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-c9725eea66
cog-0.3.0-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-d52c4e1174
cog-0.3.0-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-c9725eea66
cog-0.3.0-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-d52c4e1174
cog-0.3.0-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
cog-0.3.0-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.