Spec URL: https://raw.githubusercontent.com/johnkim76/rpmbuild_files/master/SPECS/python-openshift.spec SRPM URL: https://github.com/johnkim76/rpmbuild_files/raw/master/SRPMS/python-openshift-0.8.1-1.el7.src.rpm Description: Python client for the kubernetes API Fedora Account System Username: jkim
(just fixing expected review bug title)
Some comments: - Do we need epoch = 1, it's a bit weird to bump it for a new package (I guess it's for compatibility with builds for non-fedora). - Line 74: "Provides: %{name}-doc" must be removed, subpackage name provides is automatic. - Hidden directory /usr/share/doc/python-openshift-doc/html/.doctrees should be removed after doc building. - There are errors related to shebang/permissions with file client.py: python3-openshift.noarch: E: wrong-script-interpreter /usr/lib/python3.7/site-packages/openshift/dynamic/client.py /usr/bin/env python python3-openshift.noarch: E: non-executable-script /usr/lib/python3.7/site-packages/openshift/dynamic/client.py 644 /usr/bin/env python If those are intended to be used as scripts, fix shebang (/usr/bin/env python should not be used, but versioned one) and make them executable. Otherwise, shebang should be removed and permissions should be kept to 644.
the python openshift restclient changed versions at one point from 1.0.0-RC1 to 0.x. While they're not in Fedora there are packages floating around in our Copr repo and brew that do have this old version. You'll find these in brew, for instance. If it's not a problem I'd prefer to leave it. We'll work on fixing the rest of these.
(In reply to Jason Montleon from comment #3) > the python openshift restclient changed versions at one point from 1.0.0-RC1 > to 0.x. While they're not in Fedora there are packages floating around in > our Copr repo and brew that do have this old version. You'll find these in > brew, for instance. If it's not a problem I'd prefer to leave it. ok, let's keep it, no problem. > > We'll work on fixing the rest of these.
Added a PR removing shebang + main function: https://github.com/openshift/openshift-restclient-python/pull/252
ok, i think we can live with it until it's fixed upstream, could you update the spec with the rest of fixes so that i can re-run fedora-review?
I've created PR addressing the changes besides the ones from Fabian at https://github.com/johnkim76/rpmbuild_files/pull/3 Thanks!
Daniel, thank you. Just gave it a quick check and mereged it. Updated Links: Spec URL: https://raw.githubusercontent.com/johnkim76/rpmbuild_files/master/SPECS/python-openshift.spec SRPM URL: https://github.com/johnkim76/rpmbuild_files/raw/master/SRPMS/python-openshift-0.8.1-2.fc30.src.rpm
Note that, we need to get all requires and buildrequires in rawhide before approving python-openshift, in this case python-dictdiffer and python-string_utils need to be added first.
Dependencies have been built. dictdiffer: https://koji.fedoraproject.org/koji/buildinfo?buildID=1178439 https://koji.fedoraproject.org/koji/buildinfo?buildID=1179337 https://koji.fedoraproject.org/koji/buildinfo?buildID=1178435 and string_utils: https://koji.fedoraproject.org/koji/buildinfo?buildID=1179408 https://koji.fedoraproject.org/koji/buildinfo?buildID=1179404 https://koji.fedoraproject.org/koji/buildinfo?buildID=1179405 And submitted for testing in the case of F29: https://bodhi.fedoraproject.org/updates/FEDORA-2019-a95d01874c https://bodhi.fedoraproject.org/updates/FEDORA-2019-7c2c720ea7 And EPEL7: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-67b0214f93 https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-fc3b3523cb Along with other newly built dependencies on EPEL7: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-bf69cd4c68 https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-2a28713541 When this request is approved we'll do the same for python-openshift
Updated Links: Spec URL: http://people.redhat.com/jmontleo/pk-epel/python-openshift.spec SRPM URL: http://people.redhat.com/jmontleo/pk-epel/python-openshift-0.8.4-1.fc29.src.rpm
Some comments: - Directories /usr/lib/python3.7/site-packages/openshift are orphaned. Lines %{python2_sitelib}/%{library}/* and %{python3_sitelib}/%{library}/* should be %{python2_sitelib}/%{library} and %{python3_sitelib}/%{library} (without "/*") so that the directory itself is included in the package. Could this be fixed?, fedora-review is complaining about it. Also some other comments (not blocking approval): - It'd be great to run unit tests in %check. What deps are missing to be able to run them?, it'd be nice to fix it as follow up. - About requirements.txt and adding deps to setup.py, they could be totally removed and rely on rpm requires for dependencies management.
I think the missing deps for tests were bdd and kubernetes. We have kubernetes now and we don't need bdd for unit tests. So I've added unit tests, removed the /* to stop orphaning the dirs, and cleaned up the sed for EL7. http://people.redhat.com/jmontleo/pk-epel/python-openshift.spec http://people.redhat.com/jmontleo/pk-epel/python-openshift-0.8.4-2.fc29.src.rpm
(In reply to Jason Montleon from comment #13) > I think the missing deps for tests were bdd and kubernetes. We have > kubernetes now and we don't need bdd for unit tests. > > So I've added unit tests, removed the /* to stop orphaning the dirs, and > cleaned up the sed for EL7. > > http://people.redhat.com/jmontleo/pk-epel/python-openshift.spec > http://people.redhat.com/jmontleo/pk-epel/python-openshift-0.8.4-2.fc29.src. > rpm Thanks for all those fixes.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Apache License (v2.0)", "Unknown or generated", "Apache License (v2.0)". 818 files have unknown license. Detailed output of licensecheck in /tmp/1659286-python- openshift/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-openshift , python-openshift-doc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-openshift-0.8.4-2.fc30.noarch.rpm python-openshift-doc-0.8.4-2.fc30.noarch.rpm python-openshift-0.8.4-2.fc30.src.rpm python3-openshift.noarch: W: no-documentation python3-openshift.noarch: E: wrong-script-interpreter /usr/lib/python3.7/site-packages/openshift/dynamic/client.py /usr/bin/env python python3-openshift.noarch: E: non-executable-script /usr/lib/python3.7/site-packages/openshift/dynamic/client.py 644 /usr/bin/env python python3-openshift.noarch: W: no-manual-page-for-binary openshift-ansible-gen python-openshift-doc.noarch: W: summary-ended-with-dot C Documentation for python-openshift. 3 packages and 0 specfiles checked; 2 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- python-openshift-doc (rpmlib, GLIBC filtered): python3-openshift (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3 python3-dictdiffer python3-jinja2 python3-kubernetes python3-requests python3-ruamel-yaml python3-six python3-string_utils python3.7dist(dictdiffer) python3.7dist(jinja2) python3.7dist(kubernetes) python3.7dist(python-string-utils) python3.7dist(ruamel.yaml) python3.7dist(six) Provides -------- python-openshift-doc: python-openshift-doc python3-openshift: python3-openshift python3.7dist(openshift) python3dist(openshift) Source checksums ---------------- https://github.com/openshift/openshift-restclient-python/archive/v0.8.4.tar.gz : CHECKSUM(SHA256) this package : 0a2a19953a766aead72ab1cc01432be7d0b54c8ed6303f068bb68b3da7231d0d CHECKSUM(SHA256) upstream package : 0a2a19953a766aead72ab1cc01432be7d0b54c8ed6303f068bb68b3da7231d0d Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1659286 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 Notes: - About shebang issue in openshift/dynamic/client.py , it has been fixed upstream but not released yet so it will be fixed in new release. Package is APPROVED
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-openshift
Fedora 29 and 30 builds are done: https://koji.fedoraproject.org/koji/buildinfo?buildID=1185100 https://koji.fedoraproject.org/koji/buildinfo?buildID=1184872 The Fedora 29 package is in testing now. python-kubernetes, needed to run tests, just became possible to push to stable in EPEL today. Once there we can complete the EL7 build.