Bug 1661106 - [cloud-CA] Clusterautoscaler in 4.0 the flag "--node-group-auto-discovery" are not supported
Summary: [cloud-CA] Clusterautoscaler in 4.0 the flag "--node-group-auto-discovery" ar...
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Cloud Compute
Version: 4.1.0
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
: 4.1.0
Assignee: Andrew McDermott
QA Contact: sunzhaohua
Depends On:
TreeView+ depends on / blocked
Reported: 2018-12-20 06:51 UTC by sunzhaohua
Modified: 2019-03-22 12:47 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2019-03-22 12:47:37 UTC
Target Upstream Version:

Attachments (Terms of Use)

Description sunzhaohua 2018-12-20 06:51:05 UTC
Description of problem:
The CA in 4.0 discovers all machinesets automatically without any flags needing to be specified. It only uses machinesets that have min/max bounds specified. So even we specify it we don't process it. To avoid misunderstanding, we should hide it or have some explanation.

Version-Release number of selected component (if applicable):
$ bin/openshift-install version
bin/openshift-install v0.7.0-master-52-ga2e193ab5b9501f7ed2758856bc3ae2f24c21a82

How reproducible:

Steps to Reproduce:
1. Deploy cluster autoscaler
2. Set flags "- --node-group-auto-discovery=asg:tag=groupA"
$ oc edit deploy cluster-autoscaler-default
      - args:
        - --logtostderr
        - --cloud-provider=cluster-api
        - --namespace=openshift-cluster-api
        - --node-group-auto-discovery=asg:tag=groupA
        - --scale-down-enabled=true
        - --scale-down-delay-after-add=10s
        - --scale-down-delay-after-delete=10s
        - --scale-down-delay-after-failure=10s
        - --scale-down-unneeded-time=10s

3. Create pod to scale up the cluster and check autoscaler log

Actual results:
This flag has no impact on the autoscaler.

$ oc logs -f cluster-autoscaler-default-6c5f868845-qnm95
I1220 03:18:39.575438       1 scale_up.go:584] Scale-up: setting group openshift-cluster-api/qe-zhsun-worker-us-east-2c size to 3
I1220 03:18:49.743649       1 scale_up.go:584] Scale-up: setting group openshift-cluster-api/qe-zhsun-worker-us-east-2b size to 3

Expected results:
Hiden the flag to avoid misunderstanding.

Additional info:

Comment 2 Michael Gugino 2019-03-22 12:47:37 UTC
The flag node-group-auto-discovery is for the aws provider and operates on existing autoscale groups.  It does not have anything to do with machinesets.

Note You need to log in before you can comment on or make changes to this bug.