This service will be undergoing maintenance at 00:00 UTC, 2017-10-23 It is expected to last about 30 minutes
Bug 166185 - Review Request: perl-Class-DBI-AbstractSearch : Abstract Class::DBI's SQL with SQL::Abstract
Review Request: perl-Class-DBI-AbstractSearch : Abstract Class::DBI's SQL wit...
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Paul Howarth
David Lawrence
Depends On: 166184
Blocks: FE-ACCEPT 166203
  Show dependency treegraph
Reported: 2005-08-17 16:20 EDT by Tom "spot" Callaway
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2005-09-08 11:39:29 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
Patch addressing review issues (1.50 KB, patch)
2005-09-06 07:36 EDT, Paul Howarth
no flags Details | Diff

  None (edit)
Description Tom "spot" Callaway 2005-08-17 16:20:08 EDT
Spec Name or Url:

SRPM Name or Url:


Abstract Class::DBI's SQL with SQL::Abstract.

(NOTE: This package is one of the Maypole dependencies)
Comment 1 Paul Howarth 2005-09-06 07:35:36 EDT

- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is same as perl, matches spec
- spec file written in English and is legible
- sources match upstream
- package builds ok in FC4 and in mock for development (i386)
- BR's mostly OK
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets


- remove redundant BR: perl
- include license text


- honor %{?_smp_mflags}
- add BR: perl(DBD::SQLite) for better test coverage
Comment 2 Paul Howarth 2005-09-06 07:36:36 EDT
Created attachment 118493 [details]
Patch addressing review issues
Comment 4 Paul Howarth 2005-09-08 06:20:23 EDT

Note You need to log in before you can comment on or make changes to this bug.