Spec Name or Url: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-AbstractSearch.spec SRPM Name or Url: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-AbstractSearch-0.05-2.src.rpm Description: Abstract Class::DBI's SQL with SQL::Abstract. (NOTE: This package is one of the Maypole dependencies)
Review: - rpmlint clean - package and spec naming OK - package meets guidelines - license is same as perl, matches spec - spec file written in English and is legible - sources match upstream - package builds ok in FC4 and in mock for development (i386) - BR's mostly OK - no locales, libraries, subpackages or pkgconfigs to worry about - not relocatable - no directory ownership or permissions issues - no duplicate files - %clean section present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime - no scriptlets Needswork: - remove redundant BR: perl - include license text Nitpick: - honor %{?_smp_mflags} - add BR: perl(DBD::SQLite) for better test coverage
Created attachment 118493 [details] Patch addressing review issues
Fixed in -3: SRPM: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-AbstractSearch-0.05-3.src.rpm SPEC: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-AbstractSearch.spec
Approved.