Bug 1661916

Created attachment 1516541 [details]
Ansible uninstall log

Description of problem:

As per [1], if the mount /var/lib/origin/openshift.local.volumes is created separately before installing Openshift (without setting 'container_runtime_extra_storage' var, the uninstall playbook will umount this mount point as well. When a re-run of the installation will happen, the new pods get created in the parent mount of /var instead.

[1] - https://docs.openshift.com/container-platform/3.11/day_two_guide/environment_health_checks.html#day-two-guide-storage

Version-Release number of the following components:

# rpm -q openshift-ansible
openshift-ansible-3.11.43-1.git.0.fa69a02.el7.noarch
# rpm -q ansible
ansible-2.6.7-1.el7ae.noarch
# ansible --version
ansible 2.6.7
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /bin/ansible
  python version = 2.7.5 (default, Sep 12 2018, 05:31:16) [GCC 4.8.5 20150623 (Red Hat 4.8.5-36)]

How reproducible:

Always

Steps to Reproduce:
1. Create /var/lib/origin/openshift.local.volumes mount and install Openshift without setting 'container_runtime_extra_storage' var.
2. Run Uninstall playbook 

Actual results:

As per the following playbook and lines:

PLAYBOOK: /usr/share/ansible/openshift-ansible/playbooks/adhoc/uninstall_openshift.yml

   188    - shell: find /var/lib/origin/openshift.local.volumes -type d -exec umount {} \; 2>/dev/null || true
   189      changed_when: False

If you were to run the below command on the nodes where /var/lib/origin/openshift.local.volumes is mounted, it will unmount the /var/lib/origin/openshift.local.volumes FS too.


Expected results:

The customer expects that if the playbook is not creating any mounts, it should ideally not perform any umounts as well. If the variable 'container_runtime_extra_storage' is defined for the same install and uninstall playbooks then it would perform as expected. 

Not sure if this qualifies as a doc bug to add a note to set 'container_runtime_extra_storage' variable when creating this mount or the playbook should handle this logic. The intention is to have idempotent runs of install and uninstall playbooks with regard to working upon /var/lib/origin/openshift.local.volumes mount.