Spec Name or Url: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-mysql.spec SRPM Name or Url: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-mysql-0.23-2.src.rpm Description: Extensions to Class::DBI for MySQL (NOTE: This package is one of the Maypole dependencies)
Review: - rpmlint clean - package and spec file naming OK - package meets guidelines - license is same as perl, matches spec - spec written in English and is legible - source matches upstream - package builds OK in mock on FC4 (i386) - BR's mostly OK - no locales, libraries, subpackages or pkgconfigs to worry about - not relocatable - no directory ownership or permissions issues - no duplicate files - %clean section present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime - no scriptlets Needswork: - redundant BR: perl - license text not included - BR: perl(DBD::mysql) needed; I suspect that this may also be needed as a manual Requires:, as might perl(DBD::SQLite) for the SQLite equivalent of this module, but I don't know enough to confirm this Suggestions: - the module tries to use Time::Piece::MySQL if it's available; since this module is available in Extras, it might be useful to include this as a manual dependency - use %{?_smp_mflags}
Created attachment 118383 [details] Patch addressing review issues
Fixed in -3. SRPM: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-mysql-0.23-3.src.rpm SPEC: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-mysql.spec
Approved.