Spec Name or Url: http://www.auroralinux.org/people/spot/review/Maypole/perl-IO-CaptureOutput.spec SRPM Name or Url: http://www.auroralinux.org/people/spot/review/Maypole/perl-IO-CaptureOutput-1.03-2.src.rpm Description: Capture STDOUT/STDERR from subprocesses and XS/C modules (NOTE: This package is one of the Maypole dependencies)
Review: - rpmlint clean - package name okay - spec file name okay - package meets PackagingGuidelines - license okay - license matches upstream - spec file in am. english (and legible) - source matches upstream - package builds on FC-4 - no locales - no shared libs - not relocatable - owns all created directories - no duplicate %files - file permissions okay - %clean okay - consistent use of macros - code, not content - no -docs package - no -devel package Needswork: Testing resulted in this output: > t/capture.........ok > 3/13 skipped: Inline->bind failed : This innvocation of Inline requires the Parse::RecDescent module. > t/capture_exec....ok > t/pod.............skipped > all skipped: Test::Pod 1.00 required for testing POD > t/pod_coverage....skipped > all skipped: Test::Pod::Coverage 1.00 required for testing pod coverage I see that perl(Inline) is a BR for testing, but the named modules should also be added to the BRs for complete test coverage. Nitpicks: - BuildRequires: perl >= 1:5.6.1 - make called without %{_smp_mflags}
All items fixed in -3: New SRPM: http://www.auroralinux.org/people/spot/review/Maypole/perl-IO-CaptureOutput-1.03-3.src.rpm New SPEC: http://www.auroralinux.org/people/spot/review/Maypole/perl-IO-CaptureOutput.spec
Still needs BR: perl(Test::Pod) for full test coverage. Add that and I'll approve it.
Doh. I thought T::P::C would drag it in. I was wrong. Fixed in -4. New SRPM: http://www.auroralinux.org/people/spot/review/Maypole/perl-IO-CaptureOutput-1.03-4.src.rpm New SPEC: http://www.auroralinux.org/people/spot/review/Maypole/perl-IO-CaptureOutput.spec
Okay, it's approved.