Spec Name or Url: http://www.auroralinux.org/people/spot/review/Maypole/perl-Ima-DBI.spec SRPM Name or Url: http://www.auroralinux.org/people/spot/review/Maypole/perl-Ima-DBI-0.33-2.src.rpm Description: Database connection caching and organization (NOTE: This package is one of the Maypole dependencies)
This package requires perl(Class::WhiteHole), but I can't find it with a yum provides or in a review request. Once that's available, I'll be happy to review this package.
perl-Class-Whitehole provides it...
(In reply to comment #2) > perl-Class-Whitehole provides it... Oh. I wonder why yum provides didn't find it. Anyway, I'll ignore the obvious package name mismatch and start my review.
Review: - rpmlint clean - package name okay - spec file name okay - meets PackagingGuidelines - license okay - license matches upstream - spec file in am. english (and legible) - source matches upstream - builds on FC-4 - BR looks good - no locales - not relocatable - owns all created directories - no duplicate %files - file permissions okay - %clean okay - consistent use of macros - code, not content - no -docs package - no -devel package Nitpicks: - BuildRequires: perl >= 1:5.6.1 - make without %{_smp_mflags} - README not in %doc. This was going to be a needswork, but the README is just a copy of the Ima::DBI POD--and not even formatted at that--so it'd be a waste to include in %doc. Looks good. Approved.