Hide Forgot
Description of problem: RemovedManagementStateOnHold should be updated to PendingRemove in README.md for cluster-samples-operator repo Version-Release number of selected component (if applicable): ./openshift-install v0.8.0 How reproducible: always Steps to Reproduce: 1. Get samplesresource oc get samplesresource -o yaml - lastTransitionTime: 2018-12-25T10:11:13Z lastUpdateTime: 2018-12-25T10:11:13Z status: "False" type: PendingRemove 2.In part of :https://github.com/openshift/cluster-samples-operator#conditions RemovedManagementStateOnHold should be PendingRemove according to samplesresource 3. Actual results: In part of :https://github.com/openshift/cluster-samples-operator#conditions, RemovedManagementStateOnHold exists Expected results: RemovedManagementStateOnHold should be updated to PendingRemove Additional info:
also should update ImportCredentialsExist to ImportCredentialsExists according to： https://github.com/openshift/cluster-samples-operator/blob/master/pkg/apis/samplesoperator/v1alpha1/types.go#L158 and should update ImageChangesInProgress to ChangesInProgress according to :https://github.com/openshift/cluster-samples-operator/blob/master/pkg/apis/samplesoperator/v1alpha1/types.go#L172 here's samplersource yaml: - x86 conditions: - lastTransitionTime: 2018-12-25T10:11:41Z lastUpdateTime: 2018-12-25T10:11:41Z status: "True" type: SamplesExist - lastTransitionTime: 2018-12-25T10:11:13Z lastUpdateTime: 2018-12-25T10:11:13Z status: "False" type: ImportCredentialsExists - lastTransitionTime: 2018-12-27T02:44:35Z lastUpdateTime: 2018-12-27T02:44:35Z message: architecture x86 unsupported; only support x86_64 and ppc64le status: "False" type: ConfigurationValid - lastTransitionTime: 2018-12-27T02:17:46Z lastUpdateTime: 2018-12-27T02:17:46Z status: "False" type: ChangesInProgress - lastTransitionTime: 2018-12-25T10:11:13Z lastUpdateTime: 2018-12-25T10:11:13Z status: "False" type: PendingRemove
@Ben - do we want to make at least these name changes QE is requesting? I at least don't agree with the ones in https://bugzilla.redhat.com/show_bug.cgi?id=1662258#c1 But I could be convinced to do https://bugzilla.redhat.com/show_bug.cgi?id=1662258#c0
For comment 1 I vote for: RemovedManagementStateOnHold -> RemovePending (not PendingRemove) For comment 2, fix the godoc here to be "ImportCredentialsExist" (drop the s) so it's consistent: https://github.com/openshift/cluster-samples-operator/blob/85ee5a974ca897e4b31e637454256a29ed8fe006/pkg/apis/samplesoperator/v1alpha1/types.go#L177 The other one (ImageChangesInProgress) looks to be fine, perhaps it was fixed since this bug was opened: https://github.com/openshift/cluster-samples-operator/blob/85ee5a974ca897e4b31e637454256a29ed8fe006/pkg/apis/samplesoperator/v1alpha1/types.go#L188 I think wewang's point was just to get the godoc+type names in sync, more than to prefer one vs the other.
PR https://github.com/openshift/cluster-samples-operator/pull/78 is up
PR has merged
Thanks Gabe, now types are sync with configs.samples.operator.openshift.io instance oc get configs.samples.operator.openshift.io instance -o yaml conditions: type: ConfigurationValid type: ImageChangesInProgress type: SamplesExist type: ImportCredentialsExist type: RemovePending type: MigrationInProgress type: ImportImageErrorsExist but README.md(https://github.com/openshift/cluster-samples-operator/#conditions) is not sync with configs.samples.operator.openshift.io instance, seems it's not readable
@Gabe, I assigned it, In case you miss it, thx
OK PR https://github.com/openshift/cluster-samples-operator/pull/80/files is adding in the ImportImageErrorsExist condition MigrationInProgress is still omitted ... will add that back in after the other PRs merge.
In all the churn there was still some minor tweaks to do https://github.com/openshift/cluster-samples-operator/pull/91 addresses
PR just merged
Checked Overview in README.md in cluster-samples-operator,already updated, so verified it.
reassigning to gmontero for bookkeeping.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:0758