Red Hat Bugzilla – Bug 166259
Review Request: Zile: Zile Is Lossy Emacs
Last modified: 2007-11-30 17:11:12 EST
Spec Name or Url: http://www.ultimateevil.org/~jeff/Fedora/zile.spec
SRPM Name or Url: http://www.ultimateevil.org/~jeff/Fedora/zile-2.2.1-3.src.rpm
Zile is a small Emacs clone. Zile is a customizable, self-documenting
real-time open-source display editor. Zile was written to be as
similar as possible to Emacs; every Emacs user should feel at home.
* This is my first contribution.
- rpmlint checks clean
- meets naming, packaging guidelines
- license ok (GPL), COPYING in %doc, matches source
- spec file in am. engl, legible
- sources match upstream
- no locales
- no libraries
- not relocatable
- owns all dirs it creates
- no duplicate files
- permissions ok
- clean section OK
- macro use consistent
- code, not content
- no need for -docs
- builds and runs fine on fc4 (x86)
- nothing in %doc affects runtime
- no need for -devel
- no .la, no .pc
- Missing BuildRequires: libtermcap-devel
This is a very minor needswork. Post the fixed spec and I'll approve it. (Also,
resubmit your request for cvsextras access and I'll sponsor).
New spec and http://www.ultimateevil.org/~jeff/Fedora/zile-2.2.1-4.src.rpm
posted. I'll also add it builds and runs fine on my ppc32 system.
Approved. Good job. :)
Missing "Buildrequires: texinfo":
gcc -c -I../doc -I.. -I../src -Wall -g -fexceptions -m32 -march=i386
-mtune=pentium4 -fasynchronous-unwind-tables -Wall -W -Wmissing-prototypes
-Wstrict-prototypes -Wconversion -pedantic ./mkdoc.c
makeinfo --no-header --no-split -I../doc ../doc/zile.texi >>HELP
/bin/sh: makeinfo: command not found
make: *** [HELP] Error 127
Thanks for catching that. New spec and src.rpm.
FWIW you might want to update this to the current version (2.2.4). 2.2.1 crashed
on startup on 64bit systems which will likely make the x86_64 build a bit unhappy.
(It's fixed in 2.2.2, which is what I ship in my own repository at the moment.)
Thanks, I hadn't checked the latest release in a while. Ok, I've bumped up the
source to the latest. Spec file is still in the same place. Here's the latest