Bug 1662619 - python-faker missing dependency 'text_unidecode'
Summary: python-faker missing dependency 'text_unidecode'
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: python-faker
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Juan Orti
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1740847
TreeView+ depends on / blocked
 
Reported: 2018-12-31 02:43 UTC by Dan Callaghan
Modified: 2019-09-02 03:06 UTC (History)
3 users (show)

Fixed In Version: python-faker-2.0.1-2.fc29
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-09-02 03:06:04 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Dan Callaghan 2018-12-31 02:43:10 UTC
Description of problem:
python-faker doesn't work, it is missing a dependent package 'text-unidecode'.

Version-Release number of selected component (if applicable):
python3-faker-0.9.0-1.fc29.noarch

How reproducible:
easily

Steps to Reproduce:
1. python3 -c 'import faker'

Actual results:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/lib/python3.7/site-packages/faker/__init__.py", line 4, in <module>
    from faker.factory import Factory
  File "/usr/lib/python3.7/site-packages/faker/factory.py", line 13, in <module>
    from faker.config import DEFAULT_LOCALE, PROVIDERS, AVAILABLE_LOCALES
  File "/usr/lib/python3.7/site-packages/faker/config.py", line 14, in <module>
    AVAILABLE_LOCALES = find_available_locales(PROVIDERS)
  File "/usr/lib/python3.7/site-packages/faker/utils/loading.py", line 32, in find_available_locales
    provider_module = import_module(provider_path)
  File "/usr/lib64/python3.7/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "/usr/lib/python3.7/site-packages/faker/providers/internet/__init__.py", line 4, in <module>
    from text_unidecode import unidecode
ModuleNotFoundError: No module named 'text_unidecode'

Expected results:
no missing dependencies

Additional info:
It looks like this dependency was recently introduced, for licensing reasons:
https://github.com/joke2k/faker/issues/628

but it has already been pointed out upstream that the new dependency text-unicode has a problematic license:
https://github.com/joke2k/faker/issues/727

so we probably don't want to package that one in Fedora...

Comment 1 Juan Orti 2019-02-16 17:27:17 UTC
Ups... I missed the part that text_unidecode is licensed with Artistic 1.0, upstream already migrated away from it. I'll pull those changes.

Comment 2 Oleg Girko 2019-04-23 13:19:01 UTC
It's been quite a long time since the problem was reported, and it was not fixed in upstream yet.
What about releasing the package with a patch reverting https://github.com/joke2k/faker/commit/1abef75e980ed572edd3409ec35ad843c3a625e1 ?

Comment 3 Oleg Girko 2019-04-26 16:30:31 UTC
Oops, I mean https://github.com/joke2k/faker/pull/629/commits/e32a0cd73d7e1f42e12593bf6024ba7607454f54
(the previous URL was for commit merging the whole pull request).

Comment 4 Juan Orti 2019-08-24 20:06:19 UTC
I've created a PR upstream: https://github.com/joke2k/faker/pull/990

Comment 5 Fedora Update System 2019-08-24 21:07:50 UTC
FEDORA-2019-883736394d has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-883736394d

Comment 6 Fedora Update System 2019-08-24 21:08:42 UTC
FEDORA-2019-b09a6c0c08 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-b09a6c0c08

Comment 7 Fedora Update System 2019-08-25 02:43:48 UTC
python-faker-2.0.1-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-883736394d

Comment 8 Fedora Update System 2019-08-25 05:00:12 UTC
python-faker-2.0.1-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-b09a6c0c08

Comment 9 Fedora Update System 2019-09-02 02:49:50 UTC
python-faker-2.0.1-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2019-09-02 03:06:04 UTC
python-faker-2.0.1-2.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.