Spec Name or Url: http://dmitry.butskoy.name/nail/nail.spec SRPM Name or Url: http://dmitry.butskoy.name/nail/nail-11.25-1.src.rpm Description: Nail is an enhanced mail command, which provides the functionality of the POSIX mailx command. It is derived from Berkeley Mail. Additionally to the POSIX features, nail can work with Maildir/ e-mail storage format (as well as mailboxes), supports IMAP, POP3 and SMTP procotols (including over SSL) to operate with remote hosts, handles mime types and different charsets. There are a lot of other useful features, see nail.html in the documentation. And as its ancient analogues, nail can be used as a mail script language, both for sending and receiving mail. Additional info: As now RedHat recommends to use new Maildir/ format instead of old mailboxes, the "mail" command becomes useless for mail reading, because it supports the mailbox format only. Using nail can solve this issue. In addition, nail provides many useful features, for a long time pending to be implemented in a command line interface.
Good: - rpmlint is clean - License is OK - Works with my IMAP server. :-) To be changed: - Remove the 'An' from the beginning of the Summary - BuildRoot is not Fedora standard: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - I would remove the leading spaces in the %description - Use %{_sbindir}/sendmail in the makeflags; Inconsitent use of macros - Do we really need the nail webpage???
" - Remove the 'An' from the beginning of the Summary" " - BuildRoot is not Fedora standard:" done. " - I would remove the leading spaces in the %description" I use leading spaces for paragraphs. IMHO, the description will be more readable if paragraphs will be used. Or it is not recommended? " - Use %{_sbindir}/sendmail in the makeflags;" done. " - Do we really need the nail webpage???" Why are not? :-) It seemed to me that there is no good README in this package, therefore I have added a copy of its current homepage. See new release: http://dmitry.butskoy.name/nail/nail-11.25-2.src.rpm
(In reply to comment #2) > " - I would remove the leading spaces in the %description" > I use leading spaces for paragraphs. IMHO, the description will be more > readable if paragraphs will be used. Or it is not recommended? Good, if you *wanted* it like this. > " - Do we really need the nail webpage???" > Why are not? :-) It seemed to me that there is no good README in this package, > therefore I have added a copy of its current homepage. OK. I thought the man-page is enough. But you are right a good readme is fine to have... > See new release: http://dmitry.butskoy.name/nail/nail-11.25-2.src.rpm Add this bug #166343 to the changelog... And I approve it.
Blank lines in front of paragraphs are most common. Leading spaces decrease readability and lead to a sort of stair-case effect.
Add bug #166343 to changelog. (The same source, I did not increment release for this...)
Also change leading spaces to blank lines.
Oliver, Whether you had plans to review this package? As no I am "sponsored", you can do it...
Brrr... As NOW I am sponsored, you can do it (WTF typo... :-)))
ping -b somebody :)
I'm not trying to steal this package from you Oliver, but it looks fine to me. Since there's been no answer for about a month, here's my APPROVED vote. Two minor remarks: - why don't you use "%{?_smp_mflags}" ? If the package doesn't build with it, please add a comment above the make line. Else, please add it. - krb5-devel is already required by openssl-devel, so you can remove it from the BuildRequires.
%{?_smp_mflags} -- OK krb5-devel -- nail uses gssapi stuff immediately (and checks for it before compiling). There is a hypothetical possibility that openssl will use another kerberos implementation (heimdal for example), therefore we cannot rely that openssl-devel will always imply krb5-devel ... New SRPM: http://dmitry.butskoy.name/nail/nail-11.25-3.src.rpm New SPEC: http://dmitry.butskoy.name/nail/nail.spec
Okay, go ahead and import.
> %install > make DESTDIR=$RPM_BUILD_ROOT `cat makeflags` install rm -rf $RPM_BUILD_ROOT is missing as the first command in this %install section.
Thanks, (Why rpmlint-0.71 has told nothing about this? :( ) changed in CVS.
Package Change Request ====================== Package Name: nail New Branches: EL-4 EL-5