Bug 1664122 - do not send bit-rot virtual xattrs in lookup response
Summary: do not send bit-rot virtual xattrs in lookup response
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: bitrot
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
bugs@gluster.org
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-01-07 19:07 UTC by Raghavendra Bhat
Modified: 2019-03-25 16:33 UTC (History)
1 user (show)

Fixed In Version: glusterfs-6.0
Clone Of:
Environment:
Last Closed: 2019-03-25 16:33:00 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Gluster.org Gerrit 21996 0 None Merged features/bit-rot: do not send version and signature keys in dict 2019-01-08 05:33:23 UTC

Description Raghavendra Bhat 2019-01-07 19:07:24 UTC
Description of problem:

Though bit-rot-stub xlator removes the internal bit-rot detection specific content from the dictionary of the lookup response, it fails to do so if the file has been marked as bad.

This is what is needed.
=======================

1) If the file has correct, then do not send any of the internal xattrs in the
lookup callback dictionary (which is the current behavior as of now, thus no need to worry about)

2) If the file has been marked as corrupted, then only send the bad file marker in the dictionary of lookup callback. Other internal xattrs such as version, signature etc are not needed. (As of now, for bad files, all the internal xattrs are sent in the lookup response)



Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2019-01-07 19:10:15 UTC
REVIEW: https://review.gluster.org/21996 (features/bit-rot: do not send version and signature keys in dict) posted (#1) for review on master by Raghavendra Bhat

Comment 2 Worker Ant 2019-01-08 05:33:23 UTC
REVIEW: https://review.gluster.org/21996 (features/bit-rot: do not send version and signature keys in dict) posted (#2) for review on master by Kotresh HR

Comment 3 Shyamsundar 2019-03-25 16:33:00 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-6.0, please open a new bug report.

glusterfs-6.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2019-March/000120.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.