Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1664266

Summary:	Making the message more clearly if could not hotplug core to the target numa node
Product:	Red Hat Enterprise Linux Advanced Virtualization	Reporter:	Min Deng <mdeng>
Component:	qemu-kvm	Assignee:	Laurent Vivier <lvivier>
Status:	CLOSED ERRATA	QA Contact:	Min Deng <mdeng>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	8.0	CC:	ddepaula, mdeng, micai, ngu, qzhang, rbalakri, virt-maint, xianwang, xuma, yihyu, zhenyzha
Target Milestone:	rc	Flags:	knoel: mirror+
Target Release:	8.1
Hardware:	ppc64le
OS:	Unspecified
Whiteboard:
Fixed In Version:	qemu-kvm-4.1.0-1.module+el8.1.0+3966+4a23dca1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-11-06 07:12:13 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Min Deng 2019-01-08 09:40:26 UTC

Description of problem:
Could not hotplug core to the target numa node

Version-Release number of selected component (if applicable):
qemu-kvm-3.1.0-3.module+el8+2614+d714d2bb.ppc64le
kernel-4.18.0-57.el8.ppc64le

How reproducible:
5/5

Steps to Reproduce:
1.boot up a rhel8.0 guest with similar cli
  ...-m 16G -smp 1,maxcpus=64,cores=1,threads=1,sockets=1 -numa node,nodeid=0 -numa node,nodeid=1 ...
2.hotplug a core to numa node 1
  (qemu) info hotpluggable-cpus 
 
  *Choose core 30 and 62 to hotplug,
  
 (qemu) device_add host-spapr-cpu-core,core-id=30,id=test30,node-id=1
node-id=1 must match numa node specified with -numa option
   
  (qemu) device_add host-spapr-cpu-core,core-id=62,id=test62,node-id=1
node-id=1 must match numa node specified with -numa option

3.

Actual results:
Fail to hotplug

Expected results:
Since node-id 0 owns core-id 0 to 31 and node-id 1 owns core-id 32 to 63,at least,it should work when hot-plug core 62 to numa node 1.

Additional info:

Comment 1 Min Deng 2019-01-08 09:42:25 UTC

x86 doesn't have this feature,so it's a specific ppc problem.

Comment 2 Min Deng 2019-01-08 10:10:38 UTC

After discussing the bug with Laurent,it's output problem.So we had better make the error output more directly and effectively.
Please change the message "node-id=1 must match numa node specified with -numa option" to an proper one.It looks like that it has no directly relation to cli's "-numa option" in this scenario.Thanks.

Comment 4 Laurent Vivier 2019-05-21 08:12:19 UTC

Sent patch upstream.

  numa: improve cpu hotplug error message with a wrong node-id
  https://patchwork.ozlabs.org/patch/1102588/

Comment 5 Laurent Vivier 2019-06-11 08:34:07 UTC

Patch merged upstream:

  a5bf9fbcc923 numa: improve cpu hotplug error message with a wrong node-id

Comment 6 Laurent Vivier 2019-06-11 08:37:04 UTC

Move to "POST" as the fix will come with the rebase to QEMU 4.1

Comment 8 Min Deng 2019-08-20 06:31:29 UTC

Verified the bug on the following build
qemu-kvm-4.1.0-1.module+el8.1.0+3966+4a23dca1.ppc64le
The error message becomes more understandable and the original problem has been fixed,thanks a lot.

(qemu) device_add host-spapr-cpu-core,core-id=30,id=test30,node-id=1
Error: invalid node-id, must be 0
(qemu) device_add host-spapr-cpu-core,core-id=30,id=test30,node-id=0
(qemu) device_add host-spapr-cpu-core,core-id=62,id=test62,node-id=1
Error: invalid node-id, must be 0
(qemu) device_add host-spapr-cpu-core,core-id=62,id=test62,node-id=0

Comment 10 errata-xmlrpc 2019-11-06 07:12:13 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:3723