Bug 1664742 - [CinderLib] - Adding managed storage via webadmin fails as 'volume_backend_name' driver option is allowed to be removed
Summary: [CinderLib] - Adding managed storage via webadmin fails as 'volume_backend_na...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Storage
Version: 4.3.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.3.1
: ---
Assignee: Eyal Shenitzky
QA Contact: Avihai
URL:
Whiteboard:
Depends On:
Blocks: 1539837
TreeView+ depends on / blocked
 
Reported: 2019-01-09 14:54 UTC by Avihai
Modified: 2019-05-30 14:44 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-03-13 16:39:26 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.3+


Attachments (Terms of Use)
Video of the issue (3.29 MB, video/mp4)
2019-01-09 14:54 UTC, Avihai
no flags Details
engine log and rpms.txt (66.76 KB, application/gzip)
2019-01-09 14:54 UTC, Avihai
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 96790 0 master MERGED core: use managed storage domain name as volume_backend_name 2019-01-15 06:32:58 UTC
oVirt gerrit 96791 0 master MERGED remove driver_name from managed block storage type 2019-01-14 09:05:49 UTC
oVirt gerrit 96948 0 master MERGED restapi: Update to model 4.3.21 2019-01-17 11:20:24 UTC

Description Avihai 2019-01-09 14:54:03 UTC
Created attachment 1519515 [details]
Video of the issue

Description of problem:
Try to add a storage domain via webadmin without filling or removing the  'volume_backend_name' driver option.
-> Action will fail (see attach video capture)

Engine:
2019-01-09 16:46:35,145+02 ERROR [org.ovirt.engine.core.bll.storage.disk.managedblock.GetManagedBlockStorageStatsCommand] (default task-9) [dace773a-9b04-499e-a12c-f8a7067af96e] Failed to fetch Managed block storage stats, output: '__init__() takes exactly 2 arguments (1 given)', '{}': org.codehaus.jackson.JsonParseException: Unexpected character ('_' (code 95)): expected a valid value (number, String, array, object, 'true', 'false' or 'null')
 at [Source: java.io.StringReader@a8e7f11; line: 1, column: 2]
	at org.codehaus.jackson.JsonParser._constructError(JsonParser.java:1433) [jackson-core-asl-1.9.13.jar:1.9.13]


Version-Release number of selected component (if applicable):
Software Version:4.3.0-0.4.master.20190106162157.gitd96a412.el7


How reproducible:
100%


Steps to Reproduce:
1. Try to add a managed storage domain via webadmin without filling or removing the  'volume_backend_name' driver option.
 
Actual results:
Action will fail

Expected results:
If this driver option is not a must ( in RESTAPI I do not fill it and it works) please remove it.

OR If this driver option is a must :
Either block the possibility to delete this option or make it compulsory to fill the value to this option.

Additional info:
see attach video capture

Comment 1 Avihai 2019-01-09 14:54:34 UTC
Created attachment 1519516 [details]
engine log and rpms.txt

Comment 2 Sandro Bonazzola 2019-01-28 09:34:16 UTC
This bug has not been marked as blocker for oVirt 4.3.0.
Since we are releasing it tomorrow, January 29th, this bug has been re-targeted to 4.3.1.

Comment 3 Avihai 2019-03-06 17:15:40 UTC
verified at 4.3.2.1

Comment 4 Sandro Bonazzola 2019-03-13 16:39:26 UTC
This bugzilla is included in oVirt 4.3.1 release, published on February 28th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.1 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.