Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1664855

Summary: Run iotests in qemu-kvm build %check phase
Product: Red Hat Enterprise Linux Advanced Virtualization Reporter: Jeff Nelson <jen>
Component: qemu-kvmAssignee: Karen Mezick <kmezick>
Status: CLOSED ERRATA QA Contact: CongLi <coli>
Severity: high Docs Contact:
Priority: medium    
Version: 8.0CC: areis, chayang, coli, crosa, ddepaula, jen, jsnow, juzhang, ldoktor, mrezanin, rbalakri, timao, virt-maint
Target Milestone: rcFlags: pm-rhel: mirror+
Target Release: 8.0   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: qemu-kvm-3.1.0-15.module+el8+2792+e33e01a0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1664463 Environment:
Last Closed: 2019-05-29 16:04:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1661026, 1664463    
Bug Blocks:    

Description Jeff Nelson 2019-01-09 20:46:38 UTC
Run iotests in qemu-kvm builds.

See BZ 1661026, but then add the changes from BZ 1664463:

1. Remove ||: from check commands to force build failures if iotests fail
2. add luks and nbd iotests

And then add:

3. Execute all iotests, not just some. In other words, now that python2/python3 issues have been resolved, more iotests can be enabled.

+++ This bug was initially created as a clone of Bug #1664463 +++

The implementation has a NOP bash option that allows iotests failures to be ignored. This BZ will change that behavior so that the build fails if the iotest fails.

+++ This bug was initially created as a clone of Bug #1661026 +++

Description of problem: 

We want to run iotests as part of the build process in order to catch potential issues earlier in the development cycle.

To accomplish this we will initially run 34 iotests with the -raw option and 83 iotests with the -qcow2 option. All of these tests are currently passing consistently. At a later date we will add additional iotests.

--- Additional comment from Karen Mezick on 2019-01-09 19:12:22 UTC ---

Based on discussions concerning Bug #1661026 (from which this BZ is cloned) the scope of this BZ has been expanded to include the following:

1. Remove the ||: from the check commands to force build failures if iotests fail (original scope)

2. Add luks and nbd iotests  (added)

Comment 4 Karen Mezick 2019-02-05 20:31:26 UTC
The following iotests are stable at this time and will be added to the build process for rhel8 slow train. 

This list of does not include iotests that fail (consistently or intermittently) or take greater than 25 seconds to execute.

./check -v -raw 001 002 004 005 008 009 010 011 012 021 025 032 033 048 052 063 077 086 101 104 106 120 140 143 145 150 157 159 160 162 170 171 175 181 184 221 226 232

./check -v -qcow2 001 002 003 004 005 007 008 009 010 011 012 013 017 018 019 020 021 022 024 025 027 028 029 032 033 034 035 037 038 042 043 046 047 048 049 050 052 053 058 062 063 066 068 069 072 073 074 085 086 087 089 090 091 095 097 098 102 103 104 105 107 108 110 111 117 120 126 127 130 133 134 138 140 141 142 143 144 145 150 156 157 158 162 170 174 177 179 181 182 184 187 188 189 190 195 198 201 204 209 214 217 226 232

./check -v -luks 001 002 003 004 005 008 009 010 011 012 021 025 032 033 048 052 140 143 145 157 162 174 181 184

./check -v -nbd 001 002 003 004 005 008 009 010 011 021 032 033 077 094 104 119 123 143 145 162 184

Comment 6 Karen Mezick 2019-02-05 21:59:23 UTC
Please disregard my last comment. 

My last comment was meant for this bugzilla, so sorry!

https://bugzilla.redhat.com/show_bug.cgi?id=1664463

Comment 7 Karen Mezick 2019-02-06 23:42:49 UTC
The following raw, qcow2, nbd and luks iotests are stable at this time and
will be added to the build process.

All of these iotests are currently passing consistently.

This list does not include any iotests that take greater than 25 seconds 
to execute in the interest of not adding a significant amount of time to
the build process.

./check -v -raw 001 002 003 004 005 008 009 010 011 012 021 025 032 033 045 
048 052 063 077 086 101 104 106 120 132 140 143 145 147 150 151 152 157 159 
160 162 170 171 175 181 184 194 205 208 218 221 222 226 227 232

./check -v -qcow2 001 002 003 004 005 007 008 009 010 011 012 013 017 018 019 
020 021 022 024 025 027 028 029 031 032 033 034 035 036 037 038 039 042 043 046 
047 048 049 050 052 053 054 056 057 058 060 061 062 063 065 066 068 069 072 073 
074 080 085 086 087 089 090 091 095 096 097 098 102 103 104 105 107 108 110 111 
114 117 120 122 126 127 130 132 133 134 137 138 140 141 142 143 144 145 147 150 
151 152 154 156 157 158 159 162 165 170 174 176 177 179 181 184 187 188 189 190 
191 194 195 196 198 201 202 203 204 205 206 208 209 214 216 217 218 219 222 223 
226 227 232

./check -v -luks 001 002 003 004 005 008 009 010 011 012 021 032 033 048 052 140 
143 145 157 162 174 181 184 208 218 227

./check -v -nbd 001 002 003 004 005 008 009 010 011 021 032 033 045 077 094 104 
119 123 132 143 145 147 151 152 162 181 184 194 205 208 218 222

Comment 12 Danilo de Paula 2019-02-13 22:38:41 UTC
Fix included in qemu-kvm-3.1.0-15.module+el8+2792+e33e01a0

Comment 13 CongLi 2019-02-14 08:01:52 UTC
Verified on qemu-kvm-3.1.0-15.module+el8+2792+e33e01a0:

~/build/BUILD/qemu-3.1.0/tests/qemu-iotests ~/build/BUILD/qemu-3.1.0
+ pushd tests/qemu-iotests
+ ./check -v -raw 001 002 003 004 005 008 009 010 011 012 021 025 032 033 045 048 052 063 077 086 101 104 106 120 132 140 143 145 147 150 152 157 159 160 162 170 171 175 181 184 194 205 208 218 221 222 226 227 232
./check: line 84: hostname: command not found
QEMU          -- "/builddir/build/BUILD/qemu-3.1.0/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64" -nodefaults -machine accel=qtest
QEMU_IMG      -- "/builddir/build/BUILD/qemu-3.1.0/tests/qemu-iotests/../../qemu-img" 
QEMU_IO       -- "/builddir/build/BUILD/qemu-3.1.0/tests/qemu-iotests/../../qemu-io"  --cache writeback -f raw
QEMU_NBD      -- "/builddir/build/BUILD/qemu-3.1.0/tests/qemu-iotests/../../qemu-nbd" 
IMGFMT        -- raw
IMGPROTO      -- file
PLATFORM      -- Linux/x86_64  4.14.0-49.el7a.noaead.x86_64
TEST_DIR      -- /builddir/build/BUILD/qemu-3.1.0/tests/qemu-iotests/scratch
SOCKET_SCM_HELPER -- /builddir/build/BUILD/qemu-3.1.0/tests/qemu-iotests/socket_scm_helper
001        
002        
003        
004        
005        
008        
009        
010        
011        
012        
021        
025        
032        
033        
045        
048        
052        
063        
077        
086        
101        
104        
106        
120        
132        
140        
143        
145        
147        
150        
152        
157        
159        
160        
162        
170        
171        
175        
181        
184        
194        
205        
208        
218        
221        
222        
226        
227        
232        
Passed all 49 tests
+ ./check -v -qcow2 001 002 003 004 005 007 008 009 010 011 012 013 017 018 019 020 021 022 024 025 027 028 029 031 032 033 034 035 036 037 038 039 042 043 046 047 048 049 050 052 053 054 056 057 058 060 061 062 063 065 066 068 069 072 073 074 080 085 086 087 089 090 091 095 096 097 098 102 103 104 105 107 108 110 111 114 117 120 122 126 127 130 132 133 134 137 138 140 141 142 143 144 145 147 150 151 152 154 156 157 158 159 162 165 170 174 176 177 179 181 184 187 188 189 190 191 194 195 196 198 201 202 203 204 205 206 208 209 214 216 217 218 222 223 226 227 232
./check: line 84: hostname: command not found
QEMU          -- "/builddir/build/BUILD/qemu-3.1.0/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64" -nodefaults -machine accel=qtest
QEMU_IMG      -- "/builddir/build/BUILD/qemu-3.1.0/tests/qemu-iotests/../../qemu-img" 
QEMU_IO       -- "/builddir/build/BUILD/qemu-3.1.0/tests/qemu-iotests/../../qemu-io"  --cache writeback -f qcow2
QEMU_NBD      -- "/builddir/build/BUILD/qemu-3.1.0/tests/qemu-iotests/../../qemu-nbd" 
IMGFMT        -- qcow2 (compat=1.1)
IMGPROTO      -- file
PLATFORM      -- Linux/x86_64  4.14.0-49.el7a.noaead.x86_64
TEST_DIR      -- /builddir/build/BUILD/qemu-3.1.0/tests/qemu-iotests/scratch
SOCKET_SCM_HELPER -- /builddir/build/BUILD/qemu-3.1.0/tests/qemu-iotests/socket_scm_helper
001        
002        
003        
004        
005        
007        
008        
009        
010        
011        
012        
013        
017        
018        
019        
020        
021        
022        
024        
025        
027        
028        
029        
031        
032        
033        
034        
035        
036        
037        
038        
039        
042        
043        
046        
047        
048        
049        
050        
052        
053        
054        
056        
057        
058        
060        
061        
062        
063        
065        
066        
068        
069        
072        
073        
074        
080        
085        
086        
087        
089        
090        
091        
095        
096        
097        
098        
102        
103        
104        
105        
107        
108        
110        
111        
114        
117        
120        
122        
126        
127        
130        
132        
133        
134        
137        
138        
140        
141        
142        
143        
144        
145        
147        
150        
151        
152        
154        
156        
157        
158        
159        
162        
165        
170        
174        
176        
177        
179        
181        
184        
187        
188        
189        
190        
191        
194        
195        
196        
198        
201        
202        
203        
204        
205        
206        
208        
209        
214        
216        
217        
218        
222        
223        
226        
227        
232        
Passed all 137 tests
+ ./check -v -luks 001 002 003 004 005 008 009 010 011 012 021 032 033 048 052 140 143 145 157 162 174 181 184 208 218 227
./check: line 84: hostname: command not found
QEMU          -- "/builddir/build/BUILD/qemu-3.1.0/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64" -nodefaults -machine accel=qtest
QEMU_IMG      -- "/builddir/build/BUILD/qemu-3.1.0/tests/qemu-iotests/../../qemu-img" 
QEMU_IO       -- "/builddir/build/BUILD/qemu-3.1.0/tests/qemu-iotests/../../qemu-io"  --cache writeback
QEMU_NBD      -- "/builddir/build/BUILD/qemu-3.1.0/tests/qemu-iotests/../../qemu-nbd" 
IMGFMT        -- luks (iter-time=10)
IMGPROTO      -- file
PLATFORM      -- Linux/x86_64  4.14.0-49.el7a.noaead.x86_64
TEST_DIR      -- /builddir/build/BUILD/qemu-3.1.0/tests/qemu-iotests/scratch
SOCKET_SCM_HELPER -- /builddir/build/BUILD/qemu-3.1.0/tests/qemu-iotests/socket_scm_helper
001        
002        
003        
004        
005        
008        
009        
010        
011        
012        
021        
032        
033        
048        
052        
140        
143        
145        
157        
162        
174        
181        
184        
208        
218        
227        
Passed all 26 tests
+ ./check -v -nbd 001 002 003 004 005 008 009 010 011 021 032 033 045 077 094 104 119 123 132 143 145 147 151 152 162 181 184 194 205 208 218 222
./check: line 84: hostname: command not found
QEMU          -- "/builddir/build/BUILD/qemu-3.1.0/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64" -nodefaults -machine accel=qtest
QEMU_IMG      -- "/builddir/build/BUILD/qemu-3.1.0/tests/qemu-iotests/../../qemu-img" 
QEMU_IO       -- "/builddir/build/BUILD/qemu-3.1.0/tests/qemu-iotests/../../qemu-io"  --cache writeback -f raw
QEMU_NBD      -- "/builddir/build/BUILD/qemu-3.1.0/tests/qemu-iotests/../../qemu-nbd" 
IMGFMT        -- raw
IMGPROTO      -- nbd
PLATFORM      -- Linux/x86_64  4.14.0-49.el7a.noaead.x86_64
TEST_DIR      -- /builddir/build/BUILD/qemu-3.1.0/tests/qemu-iotests/scratch
SOCKET_SCM_HELPER -- /builddir/build/BUILD/qemu-3.1.0/tests/qemu-iotests/socket_scm_helper
001        
002        
003        
004        
005        
008        
009        
010        
011        
021        
032        
033        
045        
077        
094        
104        
119        
123        
132        
143        
145        
147        
151        
152        
162        
181        
184        
194        
205        
208        
218        
222        
Passed all 32 tests
~/build/BUILD/qemu-3.1.0
+ popd
+ exit 0

Comment 14 CongLi 2019-02-18 09:37:21 UTC
Change the status to 'VERIFIED' based on comment 13.

Thanks.

Comment 19 errata-xmlrpc 2019-05-29 16:04:59 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:1293