Description of problem:

nagios-plugins-ntp contains old perl script instead of compiled binary check_ntp.

Source tree on https://github.com/nagios-plugins/nagios-plugins contains these to checks in two directories - old perl script in plugins-scripts and the c-code in plugins. So there is the name conflict and probably during rpm building the compiled binary version of check_ntp is than overwritten by the perl script.

Please, remove the perl version from the source tree or rename the perl version or somehow correct the logic of merging (name conflicts) checks/files from those directories.


Version-Release number of selected component (if applicable):

BAD 2.2.1-16.20180725git3429dad.el7 (contains perl version)
BAD 2.2.1-15.20180725git3429dad.el7 (contains perl version)
OK  2.2.1-9git5c7eb5b9.el7          (contains binary version)


How reproducible:

Update packages to latest available version.


Actual results:

# /usr/lib64/nagios/plugins/check_ntp -h
check_ntp v2.2.1.git (nagios-plugins 2.2.1)
The nagios plugins come with ABSOLUTELY NO WARRANTY. You may redistribute
copies of the plugins under the terms of the GNU General Public License.
For more information about these matters, see the file named COPYING.
Copyright (c) 2003 Bo Kersey/Karl DeBisschop

Usage: check_ntp -H <host> [-46] [-O] [-w <warn>] [-c <crit>] [-j <warn>] [-k <crit>] [-v verbose]
...

# file /usr/lib64/nagios/pluginscheck_ntp
check_ntp: Perl script, ASCII text executable


Expected results:

# /usr/lib64/nagios/plugins/check_ntp -h
check_ntp v2.2.1.git (nagios-plugins 2.2.1)
Copyright (c) 2006 Sean Finney
Copyright (c) 2006-2014 Nagios Plugin Development Team
        <devel@nagios-plugins.org>

This plugin checks the selected ntp server


WARNING: check_ntp is deprecated. Please use check_ntp_peer or
check_ntp_time instead.

Usage:
 check_ntp -H <host> [-w <warn>] [-c <crit>] [-j <warn>] [-k <crit>] [-4|-6] [-v verbose]
...

# file /usr/lib64/nagios/plugins/check_ntp
/usr/lib64/nagios/plugins/check_ntp: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked (uses shared libs), for GNU/Linux 2.6.32, BuildID[sha1]=077438a2982921aa6b395ebfaf35976f533e92c3, stripped


Additional info:

Source tree on https://github.com/monitoring-plugins/monitoring-plugins does not contain the perl script check_ntp.pl in plugins-scripts directory.