Bug 1665010
| Summary: | Should show Webhook secret and create a link to the secret | ||||||
|---|---|---|---|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Yadan Pei <yapei> | ||||
| Component: | Management Console | Assignee: | Jakub Hadvig <jhadvig> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Yadan Pei <yapei> | ||||
| Severity: | low | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 4.1.0 | CC: | aos-bugs, bmignano, jkleiner, jokerman, mmccomas, yapei | ||||
| Target Milestone: | --- | Keywords: | Reopened | ||||
| Target Release: | 4.2.0 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: |
Cause: User was not able to copy the whole webhook trigger URL since the secret value was obfuscated.
Consequence: User was not able to copy the whole webhook trigger URL since the secret value was obfuscated.
Fix: Add a link to copy the webhook trigger URL to clipboard
Result: User is able to copy the webhook trigger URL to clipboard
|
Story Points: | --- | ||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2019-10-16 06:27:41 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Yadan Pei
2019-01-10 09:22:15 UTC
We made a deliberate choice not to show the secret value on the details page to avoid users exposing it through shoulder surfing, accidentally in screenshots, etc. The value is sensitive. While this is a worse user experience, it is a compromise to improve security. The secret column is a link to a secret if we webhook uses a secret reference and should not have a value in this case. We recommend using secret references for webhook secrets. Reopening this as it is a regression from 3.11. I can understand not displaying it in plain text like we did in 3.x but we need at least to have the copy button added in like we had in 3.x that includes the full API URL. With the current implementation, a user will need to copy and paste from various places in order to construct a webhook. A copy link or button is a good compromise. Created attachment 1593755 [details]
design
Attached is the design recommendation for this bug.
Changes are not included in 4.2.0-0.nightly-2019-07-31-162901, will check on newer builds Now we have a 'Copy URL with Secret' button for users have the edit/admin permission.
Clicking on 'Copy URL with Secret', the webhook URL will be constructed
When we reference a secret in webhook like:
triggers:
- github:
secret: flurzSiPgajj7xJPDGua
type: GitHub
- generic:
secret: 25hzqgLm8PCgugCUGDEV
type: Generic
- gitlab:
secretReference:
name: mysecret
type: GitLab
Console will render a link to the secret.
Verified on registry.svc.ci.openshift.org/ocp/release:4.2.0-0.nightly-2019-08-01-113533
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:2922 |