Bug 1665501 - Pungi cannot be installed in Koji
Summary: Pungi cannot be installed in Koji
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: pungi
Version: rawhide
Hardware: All
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Lubomír Sedlář
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-01-11 15:28 UTC by Randy Barlow
Modified: 2019-01-14 09:45 UTC (History)
7 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-01-14 09:45:04 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Randy Barlow 2019-01-11 15:28:42 UTC
Description of problem:
Greetings!

I'm trying to build a Bodhi beta scratch build[0] on Rawhide today, and the build fails due to not being able to install pungi due to a missing dependency:

DEBUG util.py:490:  BUILDSTDERR: Error: 
DEBUG util.py:490:  BUILDSTDERR:  Problem: package pungi-4.1.32-3.fc30.noarch requires python3-pungi = 4.1.32-3.fc30, but none of the providers can be installed
DEBUG util.py:490:  BUILDSTDERR:   - conflicting requests
DEBUG util.py:490:  BUILDSTDERR:   - nothing provides python3.7dist(enum34) needed by python3-pungi-4.1.32-3.fc30.noarch


Version-Release number of selected component (if applicable):
pungi-4.1.32-3.fc30


Additional info:
I tried to install Pungi in a Rawhide container and it succeeded, but it only used pungi-4.1.31-3, so I expect the issue happened since that version and the issue hasn't propagated to the mirror I used yet.


[0] https://koji.fedoraproject.org/koji/taskinfo?taskID=31960017

Comment 1 Lubomír Sedlář 2019-01-11 15:38:10 UTC
I removed the explicit Requires on that package, but it seems the dependency generator puts it back do to what is in setup.py.
I'll try to fix it. It should only be happening in Rawhide.

Comment 2 Randy Barlow 2019-01-11 18:08:24 UTC
Yeah, I've only noticed it on Rawhide. Thanks Lubomír!

Comment 3 Miro Hrončok 2019-01-14 08:11:04 UTC
https://pagure.io/pungi/blob/master/f/setup.py

this has:

	
    install_requires = [
        "enum34",
        ...

The dependency generator reads that and makes it a dependency. A correct fix is not to apply this dependency on Python 3:

diff --git a/setup.py b/setup.py
index 7bffecf..ab4da26 100755
--- a/setup.py
+++ b/setup.py
@@ -57,7 +57,6 @@ setup(
     ],
     test_suite      = "tests",
     install_requires = [
-        "enum34",
         "jsonschema",
         "kobo",
         "lockfile",
@@ -67,6 +66,11 @@ setup(
         'dogpile.cache',
         'dict.sorted',
         ],
+    extras_require={
+        ':python_version=="2.7"': [
+            'enum34'
+        ]
+    },
     tests_require = [
         "mock",
         "nose",

Will test a submit an upstream PR.

Comment 4 Miro Hrončok 2019-01-14 08:15:36 UTC
[Stažené]$ rpm -qp --requires python3-pungi-4.1.32-3.fc30.noarch.rpm 
python(abi) = 3.7
python3.7dist(dict.sorted)
python3.7dist(dogpile.cache)
python3.7dist(jsonschema)
python3.7dist(kobo)
python3.7dist(lockfile)
python3.7dist(lxml)
python3.7dist(productmd)
python3.7dist(six)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PartialHardlinkSets) <= 4.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1


$ rpm -qp --requires python2-pungi-4.1.32-3.fc30.noarch.rpm 
python(abi) = 2.7
python2.7dist(dict.sorted)
python2.7dist(dogpile.cache)
python2.7dist(enum34)                    <------ HERE
python2.7dist(jsonschema)
python2.7dist(kobo)
python2.7dist(lockfile)
python2.7dist(lxml)
python2.7dist(productmd)
python2.7dist(six)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PartialHardlinkSets) <= 4.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1

Comment 5 Miro Hrončok 2019-01-14 08:17:22 UTC
https://pagure.io/pungi/pull-request/1113

Comment 6 Lubomír Sedlář 2019-01-14 09:45:04 UTC
I made a new build with the patch provided by Miro. Installing the package in Rawhide container works for me now.


Note You need to log in before you can comment on or make changes to this bug.