Bug 1666293 - Review Request: python-pastel - Bring colors to your terminal
Summary: Review Request: python-pastel - Bring colors to your terminal
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1666306 1666311 1668387
TreeView+ depends on / blocked
 
Reported: 2019-01-15 13:06 UTC by Fabio Valentini
Modified: 2019-05-12 14:19 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-05-12 14:19:06 UTC
Type: ---
Embargoed:
ngompa13: fedora-review?


Attachments (Terms of Use)

Description Fabio Valentini 2019-01-15 13:06:36 UTC
Spec URL: https://decathorpe.fedorapeople.org/packages/python-pastel.spec
SRPM URL: https://decathorpe.fedorapeople.org/packages/python-pastel-0.1.0-1.fc29.src.rpm

Description:
Pastel is a simple library to help you colorize strings in your
terminal.

It comes bundled with predefined styles:

- info: green
- comment: yellow
- question: black on cyan
- error: white on red

Features:

- Use predefined styles or add you own.
- Disable colors all together by calling with_colors(False).
- Automatically disables colors if the output is not a TTY.
- Used in cleo.

Fedora Account System Username: decathorpe

koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=32043345

Comment 1 Raphael Groner 2019-01-15 16:28:54 UTC
Are you interested in a review swap? Maybe you could look into bug #1659777.

Comment 2 Elliott Sales de Andrade 2019-01-19 05:21:34 UTC
The link to the SRPM here is broken.

Comment 3 Elliott Sales de Andrade 2019-01-19 05:22:47 UTC
Oops, ignore that comment; wrong bug.

Comment 4 Raphael Groner 2019-01-19 07:21:01 UTC
Can you please add your full name into FAS?

Comment 5 Raphael Groner 2019-01-19 07:27:15 UTC
Review swap with bug #1469767, maybe? :-)

Comment 6 Neal Gompa 2019-01-22 16:19:12 UTC
Taking this review.

Comment 7 Neal Gompa 2019-01-25 13:07:03 UTC
Review notes:

[x] Follows Fedora Packaging Guidelines
[x] Follows Fedora Python Packaging Guidelines
[x] Does not include Python 2 subpackage
[x] Package is named per guidelines
[x] Package builds and installs correctly
[x] Package licensing is correct and documented correctly

PACKAGE APPROVED.

Comment 8 Neal Gompa 2019-01-25 13:10:48 UTC
> [x] Package licensing is correct and documented correctly

Whoops, I did this for the wrong package here. This is wrong.

The licensing is actually missing from the upstream GitHub repo and in the PyPI tarball release. Please contact upstream to fix it.

Comment 9 Fabio Valentini 2019-01-25 14:14:56 UTC
Reported the missing LICENSE / COPYING file upstream:
https://github.com/sdispater/pastel/issues/5

Comment 10 Fabio Valentini 2019-05-12 14:19:06 UTC
I officially give up, as the upstream developer has not reacted at all to any of of the relevant, open bug reports blocking this package for months.

https://github.com/sdispater/poetry/issues/866
https://github.com/sdispater/cachy/issues/2
https://github.com/sdispater/pastel/issues/5
https://github.com/toastdriven/pylev/issues/11


Note You need to log in before you can comment on or make changes to this bug.