Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1666644

Summary:	[DOCS] Document openshift_master_manage_htpasswd var
Product:	OpenShift Container Platform	Reporter:	Vadim Rutkovsky <vrutkovs>
Component:	Documentation	Assignee:	Jason Boxman <jboxman>
Status:	CLOSED CURRENTRELEASE	QA Contact:	liujia <jiajliu>
Severity:	unspecified	Docs Contact:	Vikram Goyal <vigoyal>
Priority:	unspecified
Version:	unspecified	CC:	aos-bugs, jiajliu, jokerman, mmccomas, rsandu
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-04-09 02:02:47 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Vadim Rutkovsky 2019-01-16 09:36:54 UTC

Document URL:  https://docs.openshift.com/container-platform/3.11/install_config/configuring_authentication.html

Section Number and Name: Configuring identity providers

Describe the issue: 

htpasswd identity provider should mention openshift_master_manage_htpasswd can be used to avoid rewriting /etc/origin/master/htpasswd when openshift_master_htpasswd_users is empty

Suggestions for improvement: 
See https://bugzilla.redhat.com/show_bug.cgi?id=1666272

Additional information:

Comment 1 Robert Sandu 2019-01-16 11:53:15 UTC

Hi.

Cluster upgrades, for deployments made without openshift_master_htpasswd_users, are being affected by the htpasswd override. It could be really useful to add a reference for openshift_master_manage_htpasswd to documentation, like in section "2.2. Preparing for an Automated Upgrade" [1] of the upgrade document.

---

[1] https://access.redhat.com/documentation/en-us/openshift_container_platform/3.10/html/upgrading_clusters/install-config-upgrading-automated-upgrades#preparing-for-an-automated-upgrade

Comment 3 Jason Boxman 2019-02-04 18:51:58 UTC

Hi Robert,

Thanks for opening this bug. Can you confirm which versions of OpenShift this applies to?

Comment 4 Robert Sandu 2019-02-06 08:15:33 UTC

(In reply to Jason Boxman from comment #3)
> Hi Robert,
> 
> Thanks for opening this bug. Can you confirm which versions of OpenShift
> this applies to?

Hi Jason.

Tested in 3.10 and 3.11, but according to [1], it seems it affects all versions since 3.5.

---

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1465831

Comment 5 Jason Boxman 2019-02-07 21:55:45 UTC

Hi Robert,

Also, would this affect an upgrade from one z-stream release to another, such as 3.11.aa to 3.11.bb?

Thanks!

Comment 6 Robert Sandu 2019-02-08 08:22:25 UTC

(In reply to Jason Boxman from comment #5)
> Hi Robert,
> 
> Also, would this affect an upgrade from one z-stream release to another,
> such as 3.11.aa to 3.11.bb?
> 
> Thanks!

Hi Jason.

Yes, it would affect z-stream updates as well.

Comment 7 Jason Boxman 2019-02-08 17:32:23 UTC

I've changed the upgrade procedure to capture this variable by adding item 3. f. A preview is available here:

https://bz-1666644--ocpdocs.netlify.com/openshift-enterprise/latest/upgrading/automated_upgrades.html#preparing-for-an-automated-upgrade

The PR is here:

https://github.com/openshift/openshift-docs/pull/13586

Let me know if this addresses the subject of this bug.

Thanks.

Comment 8 Robert Sandu 2019-02-11 10:41:54 UTC

(In reply to Jason Boxman from comment #7)
> I've changed the upgrade procedure to capture this variable by adding item
> 3. f. A preview is available here:
> 
> https://bz-1666644--ocpdocs.netlify.com/openshift-enterprise/latest/
> upgrading/automated_upgrades.html#preparing-for-an-automated-upgrade
> 
> The PR is here:
> 
> https://github.com/openshift/openshift-docs/pull/13586
> 
> Let me know if this addresses the subject of this bug.
> 
> Thanks.

Hi Jason.

I believe the change addresses the bug clearly enough.

Thank you.

Comment 9 Jason Boxman 2019-02-14 21:36:33 UTC

Hi Jia,

Can you test the documentation change in #7 and confirm that it works?

Thanks.

#7 https://bugzilla.redhat.com/show_bug.cgi?id=1666644#c7

Comment 10 liujia 2019-02-18 09:59:02 UTC

Refer to steps in https://bugzilla.redhat.com/show_bug.cgi?id=1666272#c13

Verified the variable openshift_master_manage_htpasswd=false works well.

The doc LGTM.

Comment 11 Jason Boxman 2019-02-20 01:41:48 UTC

I've merged the PR into master and enterprise-3.11 branches:

master - https://github.com/openshift/openshift-docs/pull/13586
3.11 - https://github.com/openshift/openshift-docs/pull/13676


The upgrade instructions for (3.9 ->) 3.10 are materially different. I need to create a new PR with the change tailored for those instructions.

Thanks.

Comment 14 liujia 2019-03-01 09:00:39 UTC

Verified on openshift-ansible-3.11.90-1.git.0.ee0870c.el7.noarch

The new doc in comment12, lgtm.

Comment 15 Jason Boxman 2019-03-05 01:32:31 UTC

Thanks!

I've merged the PR: https://github.com/openshift/openshift-docs/pull/13879