Description of problem: Running Fedora 29 xfce + xfwm4 in VMware Workstation. A change of the VM screen size is handled properly by most components, except that 'maximizing' a window changes the window size to the previous screen size. This didn't happen before upgrading from F27 to F29. xfwm4 complains twice with this warning when the VM screen size is changed: (xfwm4:55331): xfwm4-WARNING **: 14:31:44.773: output size (1902x1045) and logical screen size (1920x1200) do not match Changing the screen size again shows that the logical screen size was in the end updated after all: (xfwm4:55331): xfwm4-WARNING **: 14:31:50.728: output size (1837x987) and logical screen size (1902x1045) do not match Adding some debug output reveals that the monitors_changed_cb() and the size_changed_cb() event handlers both call myScreenComputeSize(), which leads to the warning being show twice. It looks like WidthOfScreen() and HeightOfScreen() as called from myScreenComputeSize() still give the old values at the moment of handling the events. Perhaps the order in which Xlib (which I believe provides these functions) and gdk/gtk are updated is notified of a screen size change may not be depended on? Version-Release number of selected component (if applicable): Fedora 29 xfwm4 4.13.1 VMware Workstation 12.5.9 MS Windows 10 How reproducible: Easily on my set-up... Steps to Reproduce: 1. Run xfce in a VMware Workstation VM 2. Change the VM screen size (by resizing the window in which it is running) 3. Maximize a window handled by xfwm Actual results: Window is not full screen Expected results: Window is full screen Additional info:
That's nice work troubleshooting the issue. Would you be able to file this upstream or would you prefer that I do?
Assuming you know your way upstream much better than I do, I'd really appreciate if you could do so. Thanks in advance!
Since you apparently didn't have time yet to file an upstream bug report, I figured out where 'upstream' actually is, and filed https://bugzilla.xfce.org/show_bug.cgi?id=15085 I hope I did so similar to how you would have done it.
Thanks Roel. My apologies for the delay.
Did you verify it's not an issue with graphics? Please be aware it's a virtualized environment as noted in original report. Please give the output of the command "lspci |grep VGA" executed inside a terminal (e.g. open xfce4-terminal and enter this command line without the quotes) in your VM.
Besides, you should attach the output of xrandr command, executed inside a terminal in your VM.
Created attachment 1523598 [details] Output of "lspci | grep VGA"
Created attachment 1523599 [details] Output of "xrandr"
Raphael, please see the attached command outputs. I'd be surprised if some graphics issue could cause this single 'deferred logical screen size' issue, while keeping everything else working fine. Note that e.g. the desktop background is immediately properly updated on a screen size change.
Thanks for the additional information. The threads are full about "VGA compatible controller: VMware SVGA II Adapter". Please use your favored search engine. In the hope there's a working solution somewhere. Feel free to report again if there's still any issue. Be aware we can't support VMware related stuff because it's proprietary software and we've to verify there's really no valid issue from the other and evil side.
Sorry but I can't give any better help. E.g. did you read through and try the suggestions of following links? https://communities.vmware.com/thread/590991 https://forums.linuxmint.com/viewtopic.php?t=188563
So far I wasn't able to find anything useful, but I'll continue searching. Note that the first link is about pass-through of a 2nd video adapter, which is not applicable for my situation, and the 2nd link only suggests running Mint natively. Perhaps I should try that ;-) Please also note that this issue didn't occur with F27 (running on the same VM, with the same VMware Workstation version), so it could be considered a regression. And AFAIK, the vmware video driver is open source; I'm also using the open-vm-tools package(s) instead of the 'official' VMware tools. I'm currently using an ugly workaround where myScreenComputeSize() is called from handleConfigureNotify(), which is called quite regularly. It is called quickly after size_changed_cb(), but with up-to-date values for WidthOfScreen() and HeightOfScreen(). This way, at least the internal logical screen size state is updated, which allows for (manual) re-maximizing a window.
Great work! We should try to file your patch to upstream.
See upstream ticket https://bugzilla.xfce.org/show_bug.cgi?id=15085 attachment.
(In reply to Roel van de Kraats from comment #14) > See upstream ticket https://bugzilla.xfce.org/show_bug.cgi?id=15085 > attachment. OK, thanks. Hopefully there's a reply from upstream soonish.
See the fix in the upstream ticket. I successfully tested the fix against the Fedora xfwm4-4.13.1-4 package on my F29 system.
I have applied the upstream patch. Can you test this build please? https://koji.fedoraproject.org/koji/taskinfo?taskID=34346797
Thanks Mukundan! xfwm4-4.13.1-7.fc29.x86_64.rpm is running fine on my system (the one mentioned in the bug report).
Thanks for testing. I will push this as an update.
xfwm4-4.13.1-8.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-fa398c683c
xfwm4-4.13.1-8.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-f1b877216d
xfwm4-4.13.1-8.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-f1b877216d
xfwm4-4.13.1-8.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-fa398c683c
xfwm4-4.13.1-8.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
xfwm4-4.13.1-8.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.
For the record, the new build also seems to have fixed bug 1656444, thanks.