Bug 1666844 - Review Request: perl-Archive-Cpio - Perl library for accessing Cpio archives
Summary: Review Request: perl-Archive-Cpio - Perl library for accessing Cpio archives
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: FE-Legal
TreeView+ depends on / blocked
Reported: 2019-01-16 17:50 UTC by Timothée Floure
Modified: 2019-01-18 14:16 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2019-01-18 14:16:58 UTC
Type: ---
ppisar: fedora-review-

Attachments (Terms of Use)

System ID Private Priority Status Summary Last Updated
CPAN 43597 0 None None None 2019-01-18 14:16:57 UTC

Description Timothée Floure 2019-01-16 17:50:40 UTC
Spec URL: https://fnux.fedorapeople.org/pkg-reviews/perl-Archive-Cpio/perl-Archive-Cpio.spec
SRPM URL: https://fnux.fedorapeople.org/pkg-reviews/perl-Archive-Cpio/perl-Archive-Cpio-0.10-1.fc29.src.rpm
Description: Archive::Cpio provides a few functions to read and write cpio files.
Fedora Account System Username: fnux

Comment 1 Petr Pisar 2019-01-18 14:16:58 UTC
The standalone and in-SRPM spec file differ. It's a only a white space change. I will use the standalone for this review.

Url and Source archive addresses are Ok.
Source0 archive (SHA-256: 246fb31669764e78336b2191134122e07c44f2d82dc4f37d552ab28f8668bed3) is original. Ok.
Summary is Ok.

TODO: Spell "Cpio" as "cpio" in the summary.

FATAL: The source code does not provide neither declare any license.

Upstream bug tracker knows that <https://rt.cpan.org/Ticket/Display.html?id=43597>. There is an answer from a person signed as <tmp@merd.net>, but this is neither current PIXEL's address <https://metacpan.org/author/PIXEL> (<tmp@rigaux.org>) who uploaded the archive to CPAN nor the code author listed in Makefile.PL (Pixel <pixel@rigaux.org>).

I was able to find a CPAN author index from 2005 year <http://www.mit.edu/afs.new/athena/contrib/perl5/src/CPAN/sources/authors/01mailrc.txt.gz> that lists PIXEL as "Pascal Rigaux <tmp@merd.net>". But I believe Fedora needs something more material. E.g. an explicit e-mail from <pixel@rigaux.org> or any public statement signed as "Pascal Rigaux".

Note You need to log in before you can comment on or make changes to this bug.