Bug 1667019 - Button for removing cluster can be mistaken for button removing VMs
Summary: Button for removing cluster can be mistaken for button removing VMs
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.2.7
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ovirt-4.4.2
: 4.4.2.1
Assignee: Steven Rosenberg
QA Contact: Ivana Saranova
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-01-17 09:14 UTC by Jan Zmeskal
Modified: 2020-09-18 09:07 UTC (History)
6 users (show)

Fixed In Version: ovirt-engine-4.4.2.1
Clone Of:
Environment:
Last Closed: 2020-09-18 07:11:55 UTC
oVirt Team: Virt
Embargoed:
pm-rhel: ovirt-4.4+
pm-rhel: ovirt-4.5?


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 110323 0 master MERGED WebAdmin: Move the Remove cluster button to the menu 2021-02-16 15:41:58 UTC

Description Jan Zmeskal 2019-01-17 09:14:18 UTC
Description of problem:

When viewing VMs in a cluster (Compute -> Clusters), multiple VMs can be highlighted in the same way you can do it in Compute -> Virtual Machines (using Ctrl + click method). Alongside with that, Remove button is clickable in the upper right corner. It looks the same as button for removing VMs in Compute -> Virtual Machines. However, if you click it, you realize that the purpose of this button is actually to remove the cluster. I think this might it is conceivable that user who is not completely aware that they are in Compute -> Clusters might click it with the intent of removing selected VMs.

Once you click the Remove button, there's also a warning clarifying that you're about to remove a cluster. But I think it's quite possible to overlook it and just click Ok.

Version-Release number of selected component (if applicable):
4.2.7.3

How reproducible:
100 %

Steps to Reproduce:
1. In webadmin, go to Compute -> Clusters -> <your_cluster> -> Virtual Machines
2. Select multiple VMs using Ctrl + click

Actual results:
There's clickable Remove button in the upper right corner.

Expected results:
If it is possible, I think it would be very helpful if the Remove button said "Remove cluster" instead of just "Remove".

Additional info:

Comment 2 Michal Skrivanek 2019-01-18 07:33:53 UTC
That's indeed quite confusing and it's probably a general problem. Laura, any thoughts on how to improve it?

Comment 3 Laura Wright 2019-01-18 14:01:11 UTC
I think changing the button name to 'Remove Cluster' instead of just 'Remove' would be an improvement. I think it would also be a good idea to change the color of the button to red since it is a destructive action.

Comment 4 Laura Wright 2019-01-18 14:18:06 UTC
I also think it would be helpful to change the dialog from: 

Are you sure you want to remove the following items?
- cl-test21
- Default-new

to 

Are you sure you want to remove the following clusters? 
- cl-test21
- Default-new

Comment 5 Arik 2020-06-18 16:32:51 UTC
We can do the same as we did for bz 1763812 - move the Remove button to the drop-down menu (for consistency and as remove-cluster is a secondary action)

Comment 6 Ivana Saranova 2020-08-18 23:53:01 UTC
Steps:
1. In webadmin, go to Compute -> Clusters -> <your_cluster> -> Virtual Machines
2. Select multiple VMs using Ctrl + click

Results:
Remove button has been moved to the kebob menu. The remove dialog specifically lists only the cluster to be removed (items to clusters word change has not been implemented). Overall, I believe this change makes it less confusing and user shouldn't be tempted to remove the cluster by accident.

Verified in:
ovirt-engine-4.4.2.2-0.3.el8ev.noarch

Comment 7 Sandro Bonazzola 2020-09-18 07:11:55 UTC
This bugzilla is included in oVirt 4.4.2 release, published on September 17th 2020.

Since the problem described in this bug report should be resolved in oVirt 4.4.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.