Description of problem: There is no measurement units for disk size in VM disk page. Version-Release number of selected component (if applicable): 1.4.0-10 How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
Where do you miss the units? In the VM details you have the units and in create VM dialog you have "size (GB)". Can you please provide a screenshot to point the place out?
Created attachment 1522385 [details] miss_unit
*** Bug 1674473 has been marked as a duplicate of this bug. ***
https://github.com/kubevirt/web-ui-components/pull/232
How about make it look consistently with the wizard storage page, Gi -> SIZE (GI)?
This cannot be done because there might be sizes in different units per each row (Mi,Gi, etc.). We should rather add unit choosing to CreateVmDialog.
(In reply to Filip Krepinsky from comment #6) > This cannot be done because there might be sizes in different units per each > row (Mi,Gi, etc.). We should rather add unit choosing to CreateVmDialog. There is no other units except Gi on disks page currently. If it's going to have different units for them, please implement it and make it looks consistently in both places.
> There is no other units except Gi on disks page currently. If it's going to have different units for them, please implement it and make it looks consistently in both places. The thing is that we do not support to pick other units than Gi when creating the disks in UI. Hence, it is only hardcoded as Gi. But, kubevirt does support also other ones and it is present in the yaml file. So, every disk can have different unit, if created in command line. In order to represent that correctly in the UI, we show the unit per disk in VM details, since they can be different. We will implement the possibility to pick the unit per disk when creating the disk in the UI, but not yet there and than it will become consistent. Until than, I believe the current implementation is ok (even if not completely visually consistent, but correct). Moving back to on_qa.
so move it to verified as the units is added.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2019:1850