Spec URL: https://copr-be.cloud.fedoraproject.org/results/pvalena/vagrant/fedora-rawhide-x86_64/00849314-vagrant-vagrant_cloud/vagrant-vagrant_cloud.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/pvalena/vagrant/fedora-rawhide-x86_64/00849314-vagrant-vagrant_cloud/vagrant-vagrant_cloud-2.0.1-1.fc30.src.rpm Description: Ruby library for the HashiCorp Vagrant Cloud API. Fedora Account System Username: pvalena Copr build: https://copr.fedorainfracloud.org/coprs/pvalena/vagrant/build/849314/ Scratch-build: https://koji.fedoraproject.org/koji/taskinfo?taskID=32200608 Note: It is meant to be used with Vagrant 2.2.*
Sorry, I've submitted the outdated version by mistake. Here are the correct links: Spec URL: https://copr-be.cloud.fedoraproject.org/results/pvalena/vagrant/fedora-rawhide-x86_64/00849417-vagrant-vagrant_cloud/vagrant-vagrant_cloud.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/pvalena/vagrant/fedora-rawhide-x86_64/00849417-vagrant-vagrant_cloud/vagrant-vagrant_cloud-2.0.2-1.fc30.src.rpm Copr build: https://copr.fedorainfracloud.org/coprs/build/849415/ (enabled test dependent on WebMock update) Scratch-build: https://koji.fedoraproject.org/koji/taskinfo?taskID=32201805
- Is the Gem from https://rubygems.org/gems/vagrant_cloud Source0: https://rubygems.org/gems/%{vagrant_plugin_name}-%{version}.gem Package approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License". 10 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review /vagrant-vagrant_cloud/review-vagrant-vagrant_cloud/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in vagrant- vagrant_cloud-doc [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: vagrant-vagrant_cloud-2.0.2-1.fc30.noarch.rpm vagrant-vagrant_cloud-doc-2.0.2-1.fc30.noarch.rpm vagrant-vagrant_cloud-2.0.2-1.fc30.src.rpm vagrant-vagrant_cloud.noarch: W: no-documentation vagrant-vagrant_cloud.src: W: invalid-url Source1: vagrant_cloud-2.0.2-spec.tgz 3 packages and 0 specfiles checked; 0 errors, 2 warnings
Review stalled
Oh, I forgot to build it. Mattia, is it ok to build it now? It was already review+, no need to re-review I think.
Pavel, I've cleared the fedora-review flag because the script used by releng requires that the flag has to be set no more than 6 (?) weeks before the repository creation request. I also assume that the specfile should be updated to latest version and adjusted to the latest packaging guidelines. Also, it doesn't seem to be available anymore to the link posted here. I'll let the original reviewer to choose if they want to just set the flag to approved again or require an updated specfile.
(In reply to Pavel Valena from comment #4) > Oh, I forgot to build it. > > Mattia, is it ok to build it now? It was already review+, no need to > re-review I think. Repost a fresh spec and needinfo/mail me for a quick fresh review.
Thanks! SPEC: https://github.com/fedora-distgit/vagrant-vagrant_cloud/raw/rawhide/vagrant-vagrant_cloud.spec SRPM: https://github.com/fedora-distgit/vagrant-vagrant_cloud/raw/rawhide/vagrant-vagrant_cloud-3.0.5-1.fc36.src.rpm _ _ _ _ Koji scratch-build: https://koji.fedoraproject.org/koji/taskinfo?taskID=75662760 Copr build: https://copr.fedorainfracloud.org/coprs/build/2776379 Checks: - Tests: ok - Syntax check: ok - Reverse dependencies: ok - rpmlint: ok _ _ _ _ Test log: https://git.io/Ju78v
LGTM, package approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/vagrant-vagrant_cloud
Thanks!