Bug 1668662 - [v2v] Clicking cancel at final stage of migration plan creation does not stop migration process
Summary: [v2v] Clicking cancel at final stage of migration plan creation does not stop...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: V2V
Version: 5.10.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.11.0
Assignee: Brett Thurber
QA Contact: Shveta
Red Hat CloudForms Documentation
URL:
Whiteboard:
Depends On:
Blocks: 1668816 1676555
TreeView+ depends on / blocked
 
Reported: 2019-01-23 09:38 UTC by Jad Haj Yahya
Modified: 2019-12-13 15:09 UTC (History)
12 users (show)

Fixed In Version: 5.11.0.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1676555 (view as bug list)
Environment:
Last Closed: 2019-12-13 15:09:28 UTC
Category: Bug
Cloudforms Team: V2V
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
screen shot (88.97 KB, image/png)
2019-01-23 09:38 UTC, Jad Haj Yahya
no flags Details
Cancel button disabled in last page (100.16 KB, image/png)
2019-07-02 20:31 UTC, Shveta
no flags Details

Description Jad Haj Yahya 2019-01-23 09:38:43 UTC
Created attachment 1522605 [details]
screen shot

Description of problem:
Clicking cancel at final stage of migration plan creation does not stop migration process

Version-Release number of selected component (if applicable):
5.10.0.32

How reproducible:
Always

Steps to Reproduce:
1. Create migration map
2. create migration plan using map created on step 1
3. On final stage of migration plan creation, click "Cancel"

Actual results:
Migration process continued and completed successfully

Expected results:
Migration process should be stopped

Additional info:

Comment 2 Dave Johnson 2019-01-23 11:01:07 UTC
Please assess the impact of this issue and update the severity accordingly.  Please refer to https://bugzilla.redhat.com/page.cgi?id=fields.html#bug_severity for a reminder on each severity's definition.

If it's something like a tracker bug where it doesn't matter, please set the severity to Low.

Comment 3 Brett Thurber 2019-01-23 14:59:20 UTC

*** This bug has been marked as a duplicate of bug 1666799 ***

Comment 4 Jad Haj Yahya 2019-01-24 10:00:04 UTC
Hi Breet,

I am not sure about marking this bug as dup of bug 1666799 unless you mean that when bug 1666799 is fixed, my bug will be fixed also and the user will the opportunity to cancel migration process from the Wizard

Just to remind, I clicked cancel on creation wizard and  on bug 1666799, it was on different pgae

please advice.

Thanks,
Jad

Comment 5 Brett Thurber 2019-01-28 06:22:43 UTC
(In reply to Jadh from comment #4)
> Hi Breet,
> 
> I am not sure about marking this bug as dup of bug 1666799 unless you mean
> that when bug 1666799 is fixed, my bug will be fixed also and the user will
> the opportunity to cancel migration process from the Wizard
> 
> Just to remind, I clicked cancel on creation wizard and  on bug 1666799, it
> was on different pgae
> 
> please advice.
> 
> Thanks,
> Jad

You are correct.  Removing the dupe flag and re-opening.

Comment 6 vconzola 2019-01-28 15:16:43 UTC
This is working as designed, but I understand how it can be confusing. The Cancel button on the last page of the Migration Plan wizard (as shown in the screenshot) is to cancel out of the wizard, not to cancel the plan itself. I propose that we just remove or disable this button on the last page of the wizard. That will force the user to cancel a plan from within the Migration Plans page, as intended.

Comment 7 vconzola 2019-01-28 15:23:14 UTC
The UI for this issue is here: https://github.com/ManageIQ/manageiq-v2v/issues/859

Comment 8 vconzola 2019-02-01 14:56:03 UTC
Fixed by this PR: https://github.com/ManageIQ/manageiq-v2v/issues/859#event-2110466560

Comment 9 vconzola 2019-02-01 15:00:08 UTC
Sorry. Pasted the wrong link above, and apparently no way to edit a comment. Here's the correct PR link: https://github.com/ManageIQ/manageiq-v2v/pull/870

Comment 12 Shveta 2019-07-02 20:31:37 UTC
Created attachment 1586861 [details]
Cancel button disabled in last page

Comment 13 Shveta 2019-07-02 20:33:41 UTC
Cancel button is disabled but not removed .
Verifying the BZ in  5.11.0.11.20190625161125_392c61e
I have a question though , In which condition "Cancel" and Back" button will be enabled on Results page .
If never then we just remove them ?

Comment 15 vconzola 2019-07-03 19:13:06 UTC
@shveta You're correct. Since the user can never go Back or Cancel from the Results step of the wizard, the buttons should be hidden rather than disabled. Good catch. Do we need a separate BZ for this?

Comment 16 Fabien Dupont 2019-07-03 20:06:47 UTC
@Vince, I think we need another BZ as it is a different problem.
@Shveta, can you please create the new BZ ?


Note You need to log in before you can comment on or make changes to this bug.