PR: https://github.com/ManageIQ/manageiq/pull/18378
above PR (https://github.com/ManageIQ/manageiq/pull/18378) is closed in favor of https://github.com/ManageIQ/manageiq/pull/18387
https://github.com/ManageIQ/manageiq/pull/18386
PR 18386 was reverted: commit 5fdf7387539d43ea39031adc8ecb91926855fc33 Author: Satoe Imaishi <simaishi> Date: Tue Jan 29 11:47:39 2019 -0500 Revert "Merge pull request #18386 from yrudman/gaprindashvili-fixed-saving-tag-name" This reverts commit ac3a51ed367e9be4f6f89d944ec8e3b98f13c889, reversing changes made to 5d837f5765bb4a6d28589bd2536d4c7d09547caf. https://bugzilla.redhat.com/show_bug.cgi?id=1668730
Backported to gaprindashvili branch: commit 3b7bfa7f38e8d3a8bc45907a90b6d0aae6170a71 Author: Satoe Imaishi <simaishi> Date: Thu Feb 7 16:25:57 2019 -0500 Merge pull request #18436 from kbrock/tag_name_updates_hammer [HAMMER] Allow Tag names to be updated (cherry picked from commit ffe2069a7c00c568824a45c5261cc8f041592027) https://bugzilla.redhat.com/show_bug.cgi?id=1668730
New commit detected on ManageIQ/manageiq/gaprindashvili: https://github.com/ManageIQ/manageiq/commit/3b7bfa7f38e8d3a8bc45907a90b6d0aae6170a71 commit 3b7bfa7f38e8d3a8bc45907a90b6d0aae6170a71 Author: Satoe Imaishi <simaishi> AuthorDate: Thu Feb 7 16:25:57 2019 -0500 Commit: Satoe Imaishi <simaishi> CommitDate: Thu Feb 7 16:25:57 2019 -0500 Merge pull request #18436 from kbrock/tag_name_updates_hammer [HAMMER] Allow Tag names to be updated (cherry picked from commit ffe2069a7c00c568824a45c5261cc8f041592027) https://bugzilla.redhat.com/show_bug.cgi?id=1668730 app/models/classification.rb | 7 +- spec/factories/classification.rb | 16 +- spec/models/classification_spec.rb | 67 + 3 files changed, 79 insertions(+), 11 deletions(-)
New commit detected on ManageIQ/manageiq/gaprindashvili: https://github.com/ManageIQ/manageiq/commit/00a6a3cbd2981f6cc93368154c675ee791f9b794 commit 00a6a3cbd2981f6cc93368154c675ee791f9b794 Author: Yuri Rudman <yrudman> AuthorDate: Wed Jan 23 10:14:24 2019 -0500 Commit: Yuri Rudman <yrudman> CommitDate: Wed Jan 23 10:14:24 2019 -0500 Do not create new record in Tag table when editing existing tag Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1668730 app/models/classification.rb | 7 +- 1 file changed, 6 insertions(+), 1 deletion(-)
New commit detected on ManageIQ/manageiq/gaprindashvili: https://github.com/ManageIQ/manageiq/commit/5fdf7387539d43ea39031adc8ecb91926855fc33 commit 5fdf7387539d43ea39031adc8ecb91926855fc33 Author: Satoe Imaishi <simaishi> AuthorDate: Tue Jan 29 11:47:39 2019 -0500 Commit: Satoe Imaishi <simaishi> CommitDate: Tue Jan 29 11:47:39 2019 -0500 Revert "Merge pull request #18386 from yrudman/gaprindashvili-fixed-saving-tag-name" This reverts commit ac3a51ed367e9be4f6f89d944ec8e3b98f13c889, reversing changes made to 5d837f5765bb4a6d28589bd2536d4c7d09547caf. https://bugzilla.redhat.com/show_bug.cgi?id=1668730 app/models/classification.rb | 6 +- spec/models/classification_spec.rb | 25 - 2 files changed, 1 insertion(+), 30 deletions(-)
Fixed and verified in 5.9.9.0.20190225180110_28a581b test steps: 1 create tag under location with name "test" and value "test_value" 2 assign tag to some vm, observe "Location: test_value" in Smart Management section of vm 3. change name of tag from "test" to "test_new" 4. in Rails console (vmdb && bin/rails c): BEFORE fix: Tag.find_by(name: "/managed/location/test") > <Tag id: 213, name: "/managed/location/test"> Tag.find_by(name: "/managed/location/test_new") > <Tag id: 214, name: "/managed/location/test_new"> on VM screen: assigned tag disappeared AFTER fix: Tag.find_by(name: "/managed/location/test") > nil Tag.find_by(name: "/managed/location/test_new") > <Tag id: 213, name: "/managed/location/test_new"> on VM screen: still the same tag "Location: test_value" in Smart Management section of vm
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2019:0600