Spec URL: https://github.com/terminus-brut/fedpkg-jnacl/blob/master/jnacl.spec SRPM URL: https://github.com/terminus-brut/fedpkg-jnacl/blob/master/jnacl-1.0-1.fc30.src.rpm Description: Pure Java implementation of the NaCl: Networking and Cryptography library Fedora Account System Username: mkoncek
Hello, this is an unofficial review. Please read this for your reference. Summary ======= 1. rpmlint results 2. Koji scratch build failed Details ======= 1. rpmlint results ------------------ One warning on the source rpm and two warnings on the binary rpm, which I built after I patched jnacl.spec(I will describe the patch later). Here are the rpmlint results:: $ rpmlint /home/vagrant/rpmbuild/SRPMS/jnacl-1.0-1.fc29.src.rpm jnacl.src: W: invalid-license BSD 2.0 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint /home/vagrant/rpmbuild/RPMS/noarch/jnacl-1.0-1.fc29.noarch.rpm jnacl.noarch: W: incoherent-version-in-changelog 1.4.0-1 ['1.0-1.fc29', '1.0-1'] jnacl.noarch: W: invalid-license BSD 2.0 1 packages and 0 specfiles checked; 0 errors, 2 warnings. My review on the results above is as followings. 1.1. jnacl.src: W: invalid-license BSD 2.0 "BSD 2.0" should be "BSD" if upstream license is "The BSD 2-Clause License". Here is a list of good licenses for Fedora. https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses 1.2. jnacl.noarch: W: incoherent-version-in-changelog 1.4.0-1 ['1.0-1.fc29', '1.0-1'] The "1.4.0-1" entry in the changelog should be '1.0-1' if upstream release version is 1.0. See Versioning Guidelines for details. https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/ 2. Koji scratch build failed ---------------------------- Here is the result of "koji build --scratch rawhide jnacl-1.0-1.fc30.src.rpm" https://koji.fedoraproject.org/koji/taskinfo?taskID=32738169 Here is the reference to run a koji scratch build. https://fedoraproject.org/wiki/Using_the_Koji_build_system#Scratch_Builds I think "maven-source-plugin" should be added as a BuildRequires:: *** jnacl.spec.orig 2019-02-11 12:15:11.259987034 +0000 --- jnacl.spec 2019-02-11 12:40:52.521192759 +0000 *************** *** 12,17 **** --- 12,18 ---- BuildArch: noarch BuildRequires: maven-local + BuildRequires: mvn(org.apache.maven.plugins:maven-source-plugin) BuildRequires: mvn(biz.aQute.bnd:bnd-maven-plugin) BuildRequires: mvn(org.testng:testng) BuildRequires: junit Here is the Koji scratch build result of the package the above patch applied. https://koji.fedoraproject.org/koji/taskinfo?taskID=32737169 Thanks in advance, Hirotaka Wakabayashi
- Please use a more adequate name for your archive: Source0: https://github.com/neilalexander/jnacl/archive/v%{version}/%{name}-%{version}.tar.gz - Please add a comment above the patch to explain why it is needed - Please address Hirotaka Wakabayashi's comments Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD 2-clause "Simplified" License", "Unknown or generated". 3 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/jnacl/review-jnacl/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in jnacl- javadoc [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [ ]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: jnacl-1.0-1.fc30.noarch.rpm jnacl-javadoc-1.0-1.fc30.noarch.rpm jnacl-1.0-1.fc30.src.rpm jnacl.noarch: W: incoherent-version-in-changelog 1.4.0-1 ['1.0-1.fc30', '1.0-1'] jnacl.noarch: W: invalid-license BSD 2.0 jnacl-javadoc.noarch: W: invalid-license BSD 2.0 jnacl.src: W: invalid-license BSD 2.0 3 packages and 0 specfiles checked; 0 errors, 4 warnings.
I updated the files as mentioned.
LGTM, package approved.
Pasting real links for FedoraReview testing. Don't mind me, but please always post links to real content. Spec URL: https://github.com/terminus-brut/fedpkg-jnacl/raw/master/jnacl.spec SRPM URL: https://github.com/terminus-brut/fedpkg-jnacl/raw/master/jnacl-1.0-1.fc30.src.rpm
review stalled
As it turned out, this package is no longer required in our dependency chain.