Spec Name or Url: http://linux.duke.edu/~icon/misc/fe/qscintilla.spec SRPM Name or Url: http://linux.duke.edu/~icon/misc/fe/qscintilla-1.5.1-1.src.rpm Description: QScintilla is a port or Scintilla to the Qt GUI toolkit from Trolltech and runs on any operating system supported by Qt (eg. Windows, UNIX/Linux, MacOS/X).
* This is not the last version, as a result http://www.river-bank.demon.co.uk/download/QScintilla/qscintilla-1.62-gpl-1.5.1.tar.gz is not available any more. Please update * rm -rf $RPM_BUILD_ROOT should be in %install, not in %build
Hmm... Moving the rm -rf is tricky, since apparently part of the make actually installs stuff. I'll have to see how to fix this more intelligently.
After looking at the Makefiles, here's what I propose: --- qscintilla.spec.orig 2005-09-12 11:36:31.000000000 +0200 +++ qscintilla.spec 2005-09-12 12:05:13.000000000 +0200 @@ -52,19 +52,27 @@ %build -rm -rf $RPM_BUILD_ROOT pushd qt qmake qscintilla -make %{?_smp_mflags} +echo 'build: $(UICDECLS) $(OBJECTS) $(OBJMOC) $(SUBLIBS) $(OBJCOMP)' >> Makefile +make %{?_smp_mflags} build popd pushd designer qmake designer -make %{?_smp_mflags} +echo 'build: $(UICDECLS) $(OBJECTS) $(OBJMOC) $(SUBLIBS) $(OBJCOMP)' >> Makefile +make %{?_smp_mflags} build popd %install +rm -rf $RPM_BUILD_ROOT +pushd qt +make +popd +pushd designer +make +popd mkdir -pm 755 \ $RPM_BUILD_ROOT%{qtdir}/include \ $RPM_BUILD_ROOT%{qtdir}/translations
Created attachment 118705 [details] specfile patch for new version + "rm -rf" problem This patch will not work with the newer version. Version 1.65-gpl-1.6 supports INSTALL_ROOT, but still installs files in root during "make". Here's the patch, adapt it as you wish, I'm not very familiar with qmake.
And by the way, if you could include the doc/ and example/ subdir in the -devel package (or make a -docs subpackage), it would be nice.
Aurelien: Thanks for your help! Updated spec file and srpm available from: http://linux.duke.edu/~icon/misc/fe/qscintilla.spec http://linux.duke.edu/~icon/misc/fe/qscintilla-1.6-1.fc4.src.rpm
One last thing: the html documentation files in /usr/share/doc/qscintilla-devel-1.6/Scintilla/* are executable
Fixed. http://linux.duke.edu/~icon/misc/fe/qscintilla.spec http://linux.duke.edu/~icon/misc/fe/qscintilla-1.6-2.fc4.src.rpm
Review for release 2.fc4: * RPM name is OK * Source qscintilla-1.65-gpl-1.6.tar.gz is the same as upstream * Builds fine in mock * rpmlint of qscintilla looks OK * rpmlint of qscintilla-designer looks OK * rpmlint of qscintilla-devel looks OK * File list of qscintilla looks OK * File list of qscintilla-designer looks OK * File list of qscintilla-devel looks OK
Small nitpick: it would be better/cleaner if the doc file permission fix were done in the %prep section, instead of %install.
Yeah, that makes sense. One more small edit to move the permission fixups into %prep. http://linux.duke.edu/~icon/misc/fe/qscintilla.spec http://linux.duke.edu/~icon/misc/fe/qscintilla-1.6-3.fc4.src.rpm
Still looks good (even prettier :) ). APPROVED