Spec Name or Url: http://personal.stthomas.edu/jpmahowald1/fedora/review/numlockx.spec SRPM Name or Url: http://personal.stthomas.edu/jpmahowald1/fedora/review/numlockx-1.0-2.src.rpm Description: NumLockX turns on NumLock after starting X My first package, I need a sponsor and CVS. Fedora username jpmahowa
Review: Good: - rpmlint check returns: W: numlockx strange-permission numlockx.sh 0775 safe to ignore - meets naming and packaging guidelines - license ok (MIT), matches source, text included as %doc - spec is legible, in am. english - source matches upstream - package compiles on x86 (FC4) - no unnecessary, missing BuildRequires (./configure looks for xinitrc, but never uses it for anything) - no need for -devel, -docs - no locales - not relocatable - creates no new directories - no duplicate %files - permissions ok - %clean ok - macro use is consistent - code, not content - nothing in %doc affects runtime - no need for .desktop Nitpicks: - %{_bindir} is cleaner than %{_usr}/bin/ ... please make that change. - you might consider using %{version} in the Source0 line instead of hardcoding the tarball version Please change to %{_bindir} before committing, but this package is APPROVED. I'll also go sponsor you right now.
Nitpicks fixed, thanks. New version available from http://frontiernet.net/~jpmahowald/fedora/review/numlockx.spec and http://frontiernet.net/~jpmahowald/fedora/review/numlockx-1.0-3.src.rpm Importing into CVS.