Bug 1670779 - Exit code on wrong parameter is zero for many net-tools binaries
Summary: Exit code on wrong parameter is zero for many net-tools binaries
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: net-tools
Version: 29
Hardware: Unspecified
OS: Unspecified
medium
unspecified
Target Milestone: ---
Assignee: Michal Ruprich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-01-30 11:01 UTC by Michal Ruprich
Modified: 2019-03-29 19:10 UTC (History)
7 users (show)

Fixed In Version: net-tools-2.0-0.53.20160912git.fc29 net-tools-2.0-0.51.20160912git.fc28 net-tools-2.0-0.54.20160912git.fc30
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1670355
Environment:
Last Closed: 2019-03-12 22:18:44 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Patch (13.38 KB, patch)
2019-01-30 11:01 UTC, Michal Ruprich
no flags Details | Diff

Description Michal Ruprich 2019-01-30 11:01:10 UTC
Created attachment 1524992 [details]
Patch

+++ This bug was initially created as a clone of Bug #1670355 +++

+++ This bug was initially created as a clone of Bug #1427889 +++

Description of problem:
Exit codes for many net-tools binaries are 0 when using wrong parameters.

Version-Release number of selected component (if applicable):
net-tools-2.0-0.52.20160912git.el8

How reproducible:
Always

Steps to Reproduce:
1. Run any of the following:
#netstat wrongoption
#arp --wrongoption
#ipmaddr wrongoption
#ipmaddr --wrongoption
#iptunnel wrongoption
#iptunnel --wrongoption
#nameif wrongoption
#nameif --wrongoption
#plipconfig --wrongoption
#route --wrongoption
#slattach --wrongoption

2. #echo $?

Actual results:
Help gets printed every time but return code is 0, not 3(E_OPTERR).

Expected results:
Nonzero return codes.

Comment 1 Fedora Update System 2019-03-06 07:10:58 UTC
net-tools-2.0-0.54.20160912git.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-fc4efcf143

Comment 2 Fedora Update System 2019-03-06 07:11:04 UTC
net-tools-2.0-0.53.20160912git.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-2628921602

Comment 3 Fedora Update System 2019-03-06 07:11:10 UTC
net-tools-2.0-0.51.20160912git.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-15a77b9ac4

Comment 4 Fedora Update System 2019-03-06 15:13:11 UTC
net-tools-2.0-0.51.20160912git.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-15a77b9ac4

Comment 5 Fedora Update System 2019-03-06 15:57:23 UTC
net-tools-2.0-0.53.20160912git.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-2628921602

Comment 6 Fedora Update System 2019-03-06 22:27:45 UTC
net-tools-2.0-0.54.20160912git.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-fc4efcf143

Comment 7 Fedora Update System 2019-03-06 22:53:57 UTC
net-tools-2.0-0.54.20160912git.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-fc4efcf143

Comment 8 Fedora Update System 2019-03-12 22:18:44 UTC
net-tools-2.0-0.53.20160912git.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2019-03-15 03:35:21 UTC
net-tools-2.0-0.51.20160912git.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2019-03-29 19:10:21 UTC
net-tools-2.0-0.54.20160912git.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.