SPEC: https://copr-be.cloud.fedoraproject.org/results/frantisekz/flask-cors/fedora-rawhide-x86_64/00852170-python-flask-cors/python-flask-cors.spec SRPM: https://copr-be.cloud.fedoraproject.org/results/frantisekz/flask-cors/fedora-rawhide-x86_64/00852170-python-flask-cors/python-flask-cors-3.0.7-1.fc30.src.rpm This is resurrection of dead package review: https://bugzilla.redhat.com/show_bug.cgi?id=1512226 No significant changes were made, it was just updated to the latest release.
https://github.com/corydolphin/%{srcname}/archive/%{version}.tar.gz#/%{srcname}-%{version}.tar.gz github knows this: https://github.com/corydolphin/%{srcname}/archive/%{version}/%{srcname}-%{version}.tar.gz you could also use: %{url}/archive/%{version}/%{srcname}-%{version}.tar.gz -------- Requires: %{py3_dist flask six} There are automatic requires, drop this. If you target anything but rawhide, enable this manually via %{?python_enable_dependency_generator}. ------- Package uses setuptools. BuildRequire python3-setuptools explicitly. ------- Use the python_provide macro as mentioned in the Python packaging guidelines ------- I've never seen {%py3_build} only %{py3_build} or %py3_build - is this some style of yours? It evals to: {\ CFLAGS="${CFLAGS:-${RPM_OPT_FLAGS}}" LDFLAGS="${LDFLAGS:-${RPM_LD_FLAGS}}"\ /usr/bin/python3 setup.py build --executable="/usr/bin/python3 -s" sleep 1 } So the commands are grouped via {}. I don't think this was intentional. The same for %py3_install.
SPEC: https://copr-be.cloud.fedoraproject.org/results/frantisekz/flask-cors/fedora-rawhide-x86_64/00852187-python-flask-cors/python-flask-cors.spec SRPM: https://copr-be.cloud.fedoraproject.org/results/frantisekz/flask-cors/fedora-rawhide-x86_64/00852187-python-flask-cors/python-flask-cors-3.0.7-1.fc30.src.rpm All should be fixed. As for the weird {%py3_build} macros, I've probably overlooked them in the original spec file. Thanks!
BuildRequires: python3-setuptools BuildRequires: %{py3_dist flask six nose} This is kinda inconsistent with each other, but I don't really care. Let me build the package once more and run some automated checks.
CHECKSUM(SHA256) this package : 99f79b71e9df7aaab86ff873ecb269e4be7cb08ff1732c5f3a11510a2dcefc12 CHECKSUM(SHA256) upstream package : 99f79b71e9df7aaab86ff873ecb269e4be7cb08ff1732c5f3a11510a2dcefc12 License looks good. Requirements look good. Checking: python3-flask-cors-3.0.7-1.fc30.noarch.rpm python-flask-cors-3.0.7-1.fc30.src.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Enjoy your package, it's APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-flask-cors