Bug 1671273 - Review Request: python-flask-cors - Cross Origin Resource Sharing ( CORS ) support for Flask
Summary: Review Request: python-flask-cors - Cross Origin Resource Sharing ( CORS ) su...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: 29
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Miro Hrončok
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-01-31 09:44 UTC by František Zatloukal
Modified: 2019-02-02 23:23 UTC (History)
2 users (show)

Fixed In Version: python-flask-cors-3.0.7-1.fc30
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-02-02 23:23:43 UTC
mhroncok: fedora-review+


Attachments (Terms of Use)

Comment 1 Miro Hrončok 2019-01-31 10:02:03 UTC
https://github.com/corydolphin/%{srcname}/archive/%{version}.tar.gz#/%{srcname}-%{version}.tar.gz

github knows this:

https://github.com/corydolphin/%{srcname}/archive/%{version}/%{srcname}-%{version}.tar.gz

you could also use:

%{url}/archive/%{version}/%{srcname}-%{version}.tar.gz

--------


Requires:       %{py3_dist flask six}

There are automatic requires, drop this.

If you target anything but rawhide, enable this manually via %{?python_enable_dependency_generator}.


-------

Package uses setuptools. BuildRequire python3-setuptools explicitly.

-------

Use the python_provide macro as mentioned in the Python packaging guidelines

-------

I've never seen {%py3_build} only %{py3_build} or %py3_build - is this some style of yours?

It evals to:

{\
  CFLAGS="${CFLAGS:-${RPM_OPT_FLAGS}}" LDFLAGS="${LDFLAGS:-${RPM_LD_FLAGS}}"\
  /usr/bin/python3 setup.py  build --executable="/usr/bin/python3 -s" 
  sleep 1
}


So the commands are grouped via {}. I don't think this was intentional.

The same for %py3_install.

Comment 3 Miro Hrončok 2019-01-31 11:43:53 UTC
BuildRequires:  python3-setuptools
BuildRequires:  %{py3_dist flask six nose}

This is kinda inconsistent with each other, but I don't really care.

Let me build the package once more and run some automated checks.

Comment 4 Miro Hrončok 2019-01-31 12:55:21 UTC
  CHECKSUM(SHA256) this package     : 99f79b71e9df7aaab86ff873ecb269e4be7cb08ff1732c5f3a11510a2dcefc12
  CHECKSUM(SHA256) upstream package : 99f79b71e9df7aaab86ff873ecb269e4be7cb08ff1732c5f3a11510a2dcefc12

License looks good.

Requirements look good.

Checking: python3-flask-cors-3.0.7-1.fc30.noarch.rpm
          python-flask-cors-3.0.7-1.fc30.src.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

Enjoy your package, it's APPROVED.

Comment 5 Mohan Boddu 2019-02-02 22:08:46 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-flask-cors


Note You need to log in before you can comment on or make changes to this bug.