Bug 1671720 - Review Request: perl-HTML-FormatExternal - HTML to text formatting using external programs
Summary: Review Request: perl-HTML-FormatExternal - HTML to text formatting using exte...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-02-01 12:49 UTC by Petr Pisar
Modified: 2019-02-05 14:31 UTC (History)
2 users (show)

Fixed In Version: perl-HTML-FormatExternal-26-1.fc30
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-02-05 14:31:39 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2019-02-01 12:49:07 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-HTML-FormatExternal/perl-HTML-FormatExternal.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-HTML-FormatExternal/perl-HTML-FormatExternal-26-1.fc30.src.rpm
Description:
This is a common base for formatter modules which turn HTML into plain text
by dumping it through the respective external programs. Available modules are:

HTML::FormatText::Elinks
HTML::FormatText::Html2text
HTML::FormatText::Links
HTML::FormatText::Lynx
HTML::FormatText::W3m


Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2019-02-05 13:09:53 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ for i in `ls perl-HTML-FormatExternal*-26-1.fc30.noarch.rpm` ; do echo $i ; rpm -qp --requires $i | grep -v rpmlib | sort | uniq -c ; done
perl-HTML-FormatExternal-26-1.fc30.noarch.rpm
      1 perl(Carp)
      1 perl(constant)
      1 perl(Encode)
      1 perl(File::Copy)
      1 perl(File::Spec) >= 0.80
      1 perl(File::Temp) >= 0.18
      1 perl(IPC::Run)
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(strict)
      1 perl(:VERSION) >= 5.6.0
      1 perl(warnings)
perl-HTML-FormatExternal-Elinks-26-1.fc30.noarch.rpm
      1 elinks
      1 perl(constant)
      1 perl(HTML::FormatExternal)
      1 perl-HTML-FormatExternal = 26-1.fc30
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(strict)
      1 perl(URI::file) >= 0.08
      1 perl(:VERSION) >= 5.6.0
      1 perl(warnings)
perl-HTML-FormatExternal-Html2text-26-1.fc30.noarch.rpm
      1 perl(constant)
      1 perl(constant::defer)
      1 perl(HTML::FormatExternal)
      1 perl-HTML-FormatExternal = 26-1.fc30
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(strict)
      1 perl(:VERSION) >= 5.6.0
      1 perl(warnings)
      1 python3-html2text
perl-HTML-FormatExternal-Links-26-1.fc30.noarch.rpm
      1 links
      1 perl(constant)
      1 perl(constant::defer)
      1 perl(HTML::FormatExternal)
      1 perl-HTML-FormatExternal = 26-1.fc30
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(strict)
      1 perl(URI::file) >= 0.08
      1 perl(:VERSION) >= 5.6.0
      1 perl(warnings)
perl-HTML-FormatExternal-Lynx-26-1.fc30.noarch.rpm
      1 lynx
      1 perl(constant)
      1 perl(constant::defer)
      1 perl(HTML::FormatExternal)
      1 perl-HTML-FormatExternal = 26-1.fc30
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(strict)
      1 perl(URI::file) >= 0.08
      1 perl(:VERSION) >= 5.6.0
      1 perl(warnings)
perl-HTML-FormatExternal-W3m-26-1.fc30.noarch.rpm
      1 perl(constant)
      1 perl(HTML::FormatExternal)
      1 perl-HTML-FormatExternal = 26-1.fc30
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(strict)
      1 perl(URI::file) >= 0.08
      1 perl(:VERSION) >= 5.6.0
      1 perl(warnings)
      1 w3m
Binary requires are Ok.

$ for i in `ls perl-HTML-FormatExternal*-26-1.fc30.noarch.rpm` ; do echo $i ; rpm -qp --provides $i | sort | uniq -c ; done
perl-HTML-FormatExternal-26-1.fc30.noarch.rpm
      1 perl(HTML::FormatExternal) = 26
      1 perl-HTML-FormatExternal = 26-1.fc30
perl-HTML-FormatExternal-Elinks-26-1.fc30.noarch.rpm
      1 perl-HTML-FormatExternal-Elinks = 26-1.fc30
      1 perl(HTML::FormatText::Elinks) = 26
perl-HTML-FormatExternal-Html2text-26-1.fc30.noarch.rpm
      1 perl-HTML-FormatExternal-Html2text = 26-1.fc30
      1 perl(HTML::FormatText::Html2text) = 26
perl-HTML-FormatExternal-Links-26-1.fc30.noarch.rpm
      1 perl-HTML-FormatExternal-Links = 26-1.fc30
      1 perl(HTML::FormatText::Links) = 26
perl-HTML-FormatExternal-Lynx-26-1.fc30.noarch.rpm
      1 perl-HTML-FormatExternal-Lynx = 26-1.fc30
      1 perl(HTML::FormatText::Lynx) = 26
perl-HTML-FormatExternal-W3m-26-1.fc30.noarch.rpm
      1 perl-HTML-FormatExternal-W3m = 26-1.fc30
      1 perl(HTML::FormatText::W3m) = 26
Binary provides are Ok.

$ rpmlint ./perl-HTML-FormatExternal*
perl-HTML-FormatExternal.noarch: W: spelling-error %description -l en_US formatter -> formatted, for matter, for-matter
perl-HTML-FormatExternal.src: W: spelling-error %description -l en_US formatter -> formatted, for matter, for-matter
7 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2019-02-05 14:17:44 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-HTML-FormatExternal

Comment 3 Petr Pisar 2019-02-05 14:31:39 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.