Bug 1671733 - clang-format test is checking contrib files, but rfc.sh skips them
Summary: clang-format test is checking contrib files, but rfc.sh skips them
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: project-infrastructure
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-02-01 13:35 UTC by Xavi Hernandez
Modified: 2019-02-19 13:47 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-02-19 13:47:29 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:

Attachments (Terms of Use)

Description Xavi Hernandez 2019-02-01 13:35:31 UTC 
Description of problem:

The clang-format job is testing files inside 'contrib' directory. I think they shouldn't be checked, like rfc.sh already does.

Example: https://build.gluster.org/job/clang-format/2868/console

Version-Release number of selected component (if applicable):


How reproducible:

Always

Steps to Reproduce:
1. Execute the job on this patch: https://review.gluster.org/c/glusterfs/+/20636
2.
3.

Actual results:

The test fails

Expected results:

The test shouldn't fail because of invalid formatting on files inside 'contrib' directory.

Additional info:
Comment 1 Nigel Babu 2019-02-03 05:57:12 UTC 
Fixing.
Comment 2 Nigel Babu 2019-02-03 11:22:51 UTC 
Pushed https://review.gluster.org/#/c/build-jobs/+/22143 for review.
Comment 4 M. Scherer 2019-02-19 13:47:29 UTC 
Code was merged, closing
Note You need to log in before you can comment on or make changes to this bug.