Bug 1671855 - virt-clone: ERROR local variable 'need' referenced before assignment
Summary: virt-clone: ERROR local variable 'need' referenced before assignment
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: virt-manager
Version: 29
Hardware: x86_64
OS: Linux
unspecified
urgent
Target Milestone: ---
Assignee: Cole Robinson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-02-01 21:53 UTC by Chad
Modified: 2019-02-09 02:13 UTC (History)
2 users (show)

Fixed In Version: virt-manager-2.1.0-1.fc29
Clone Of:
Environment:
Last Closed: 2019-02-09 02:13:12 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Chad 2019-02-01 21:53:14 UTC
Description of problem:
Running virt-clone errors out

Version-Release number of selected component (if applicable):
virt-install-1.6.0-1.3.git3bc7ff24c.fc29.noarch

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:
[Fri, 01 Feb 2019 15:49:18 virt-clone 15046] DEBUG (cli:277)   File "/usr/share/virt-manager/virt-clone", line 213, in <module>
    fail(main_e)
  File "/usr/share/virt-manager/virtinst/cli.py", line 277, in fail
    logging.debug("".join(traceback.format_stack()))

[Fri, 01 Feb 2019 15:49:18 virt-clone 15046] ERROR (cli:278) local variable 'need' referenced before assignment
[Fri, 01 Feb 2019 15:49:18 virt-clone 15046] DEBUG (cli:280) 
Traceback (most recent call last):
  File "/usr/share/virt-manager/virt-clone", line 207, in <module>
    sys.exit(main())
  File "/usr/share/virt-manager/virt-clone", line 193, in main
    design.setup_clone()
  File "/usr/share/virt-manager/virtinst/cloner.py", line 418, in setup_clone
    self._setup_disk_clone_destination(orig_disk, clone_disk)
  File "/usr/share/virt-manager/virtinst/cloner.py", line 342, in _setup_disk_clone_destination
    clone_disk.validate()
  File "/usr/share/virt-manager/virtinst/devices/disk.py", line 882, in validate
    self._storage_backend.validate(self)
  File "/usr/share/virt-manager/virtinst/diskbackend.py", line 340, in validate
    err, msg = self.is_size_conflict()
  File "/usr/share/virt-manager/virtinst/diskbackend.py", line 383, in is_size_conflict
    if need > avail:
UnboundLocalError: local variable 'need' referenced before assignment

Expected results:


Additional info:
Fixed in upstream: https://github.com/virt-manager/virt-manager/commit/722886748006b880ff6a99781b2aca0751aafc55#diff-33560dd1575b58f1a4602a360b2d8486

Comment 1 Cole Robinson 2019-02-03 17:58:05 UTC
Fixed upstream as you mention. I'll be doing a release today

Comment 2 Fedora Update System 2019-02-03 21:54:43 UTC
virt-manager-2.1.0-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-c38a307cd5

Comment 3 Fedora Update System 2019-02-05 04:05:27 UTC
virt-manager-2.1.0-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-c38a307cd5

Comment 4 Fedora Update System 2019-02-09 02:13:12 UTC
virt-manager-2.1.0-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.