Bug 1672251 - rename fails on KeyError 'changed'
Summary: rename fails on KeyError 'changed'
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Tools.Rename
Version: 4.3.0
Hardware: Unspecified
OS: Unspecified
Target Milestone: ovirt-4.3.1
: ---
Assignee: Yedidyah Bar David
QA Contact: Petr Kubica
Depends On:
Blocks: 1660378
TreeView+ depends on / blocked
Reported: 2019-02-04 11:22 UTC by Lucie Leistnerova
Modified: 2019-03-13 16:39 UTC (History)
2 users (show)

Fixed In Version: ovirt-engine-
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2019-03-13 16:39:32 UTC
oVirt Team: Integration
rule-engine: ovirt-4.3+
lleistne: testing_ack+

Attachments (Terms of Use)
rename log (283.25 KB, text/plain)
2019-02-04 11:22 UTC, Lucie Leistnerova
no flags Details

System ID Private Priority Status Summary Last Updated
oVirt gerrit 96284 0 None None None 2019-02-04 11:25:18 UTC
oVirt gerrit 97563 0 master MERGED packaging: setup: uninstall: Do not fail rename on missing files 2019-02-05 08:45:26 UTC
oVirt gerrit 97572 0 master MERGED packaging: setup: uninstall: Do not fail remove on missing files 2019-02-05 12:58:44 UTC

Description Lucie Leistnerova 2019-02-04 11:22:06 UTC
Created attachment 1526736 [details]
rename log

Description of problem:
Running ovirt-engine-rename fails with
[ ERROR ] Failed to execute stage 'Setup validation': 'changed'

Version-Release number of selected component (if applicable):

How reproducible: always on my d/s 4.3 engines

Steps to Reproduce:
1. run /usr/share/ovirt-engine/setup/bin/ovirt-engine-rename
2. enter new hostname and yes to all

Actual results: rename failed, see attached log

Expected results: rename is successful

Additional info:

postgresql.conf doesn't have 'changed' key:
ENV OVESETUP_CORE/uninstallFilesInfo=dict:'{'/etc/pki/ovirt-engine/keys/reports.key.nopass': {'changed': False, 'groups': ['ca_pki'], 'md5': 'f6f3714166918f150d2528a9bb10d901'}, '/var/opt/rh/rh-postgresql95/lib/pgsql/data/postgresql.conf': {'groups': ['core', 'unremovable'], 'md5': '415d91ef1aa820745278fc82866fe229'}, '/etc/httpd/conf.d/ovirt-engine-root-redirect.conf': {'changed': False, 'groups': ['core'], 'md5': '161fc2c071d4bd8973796008e5fea7b8'}, '/etc/pki/ovirt-engine/cacert.conf': {'changed': False, 'groups': ['ca_pki'], 'md5': 'db0967328f0c2c544fbfc7f93f4dfa1e'}

There is maybe somehow mixed PG95, that was upgraded to PG10 
/var/opt/rh/rh-postgresql95/lib/pgsql/data/postgresql.conf no such file

Comment 1 Yedidyah Bar David 2019-02-04 11:25:19 UTC
I think it should already work for you, not sure. Moving to MODIFIED for now. Or, you can test with current upstream master snapshot.

Comment 2 Yedidyah Bar David 2019-02-04 11:26:27 UTC
No, sorry, I think it's a real bug.

Comment 3 Yedidyah Bar David 2019-02-05 08:07:57 UTC
QE: Reproduction/Verification steps:

1. Setup engine
2. Remove or rename some file that was written by engine-setup.
Removal can be done manually, or by a previous run of engine-setup itself over versions - does not matter for current bug.
3. Run ovirt-engine-rename

With a broken version, it will fail as described.

With the fixed version, it will continue.

Comment 4 Yedidyah Bar David 2019-02-05 11:25:40 UTC
Now pushed a similar patch for engine-cleanup, which is also affected the same way. Above steps apply similarly.

Comment 5 Petr Kubica 2019-03-06 15:27:33 UTC
Verified in ovirt-engine-4.3.2-0.1.el7.noarch

Comment 6 Sandro Bonazzola 2019-03-13 16:39:32 UTC
This bugzilla is included in oVirt 4.3.1 release, published on February 28th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.1 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.

Note You need to log in before you can comment on or make changes to this bug.