RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1672773 - glibc: Missing robust mutex compiler barriers in pthread_mutex_trylock.c
Summary: glibc: Missing robust mutex compiler barriers in pthread_mutex_trylock.c
Keywords:
Status: CLOSED ERRATA
Alias: None
Deadline: 2019-04-24
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: glibc
Version: 8.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: 8.1
Assignee: Patsy Griffin
QA Contact: qe-baseos-tools-bugs
URL:
Whiteboard:
Depends On: 1672771 1682593
Blocks: 1684553 1701002
TreeView+ depends on / blocked
 
Reported: 2019-02-05 21:07 UTC by Carlos O'Donell
Modified: 2023-07-18 14:30 UTC (History)
8 users (show)

Fixed In Version: glibc-2.28-48.el8
Doc Type: No Doc Update
Doc Text:
Clone Of: 1672771
Environment:
Last Closed: 2019-11-05 21:29:04 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2019:3513 0 None None None 2019-11-05 21:29:24 UTC
Sourceware 24180 0 None None None 2019-08-29 14:02:17 UTC

Description Carlos O'Donell 2019-02-05 21:07:11 UTC
+++ This bug was initially created as a clone of Bug #1672771 +++

There are 10 missing compiler barriers in pthread_mutex_trylock.c, which can under certain circumstances, allow an optimizing compiler to reorder stores such that the kernel can observe an inconsistent state in the robust list.

Stefan Liebler's (IBM) patch:
https://www.sourceware.org/ml/libc-alpha/2019-02/msg00129.html

My review:
https://www.sourceware.org/ml/libc-alpha/2019-02/msg00133.html

We should backport this to rhel-7.7, since in rhel-7.6 we did a lot of work to fix other robust mutex issues for the Samba team.

Comment 2 Carlos O'Donell 2019-02-22 19:23:07 UTC
commit 823624bdc47f1f80109c9c52dee7939b9386d708
Author: Stefan Liebler <stli.com>
Date:   Thu Feb 7 15:18:36 2019 +0100

    Add compiler barriers around modifications of the robust mutex list for pthread_mutex_trylock. [BZ #24180]

Comment 7 Sergey Kolosov 2019-09-24 12:31:59 UTC
Verified with objdump based on https://bugzilla.redhat.com/show_bug.cgi?id=1672771#c7 comment, also sanity check that patch was applied.

Comment 9 errata-xmlrpc 2019-11-05 21:29:04 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:3513


Note You need to log in before you can comment on or make changes to this bug.