Spec URL: https://jjames.fedorapeople.org/gap-pkg-smallgrp/gap-pkg-smallgrp.spec SRPM URL: https://jjames.fedorapeople.org/gap-pkg-smallgrp/gap-pkg-smallgrp-1.3-1.fc30.src.rpm Fedora Account System Username: jjames Description: The Small Groups library gives access to all groups of certain "small" orders. The groups are sorted by their orders and they are listed up to isomorphism; that is, for each of the available orders a complete and irredundant list of isomorphism type representatives of groups is given. The introduction of this package is part of an effort to upgrade the gap package to version 4.10.0 in Rawhide. The gap package has not yet been upgraded, because doing so before the introduction of this package will break sagemath. Therefore, in order to build this package for review, you will need the packages in this repository: https://copr.fedorainfracloud.org/coprs/jjames/GAP/.
The package fails to build on my machine (fedora 30 x86_64): $ rpmbuild -ba gap-pkg-smallgrp.spec ... #I autpgrp package is not available. Check that the name is correct #I and it is present in one of the GAP root directories (see '??RootPaths') #I alnuth package is not available. Check that the name is correct #I and it is present in one of the GAP root directories (see '??RootPaths') #I crisp package is not available. Check that the name is correct #I and it is present in one of the GAP root directories (see '??RootPaths') #I ctbllib package is not available. Check that the name is correct #I and it is present in one of the GAP root directories (see '??RootPaths') #I factint package is not available. Check that the name is correct #I and it is present in one of the GAP root directories (see '??RootPaths') #I fga package is not available. Check that the name is correct #I and it is present in one of the GAP root directories (see '??RootPaths') #I irredsol package is not available. Check that the name is correct #I and it is present in one of the GAP root directories (see '??RootPaths') #I laguna package is not available. Check that the name is correct #I and it is present in one of the GAP root directories (see '??RootPaths') #I polenta package is not available. Check that the name is correct #I and it is present in one of the GAP root directories (see '??RootPaths') #I polycyclic package is not available. Check that the name is correct #I and it is present in one of the GAP root directories (see '??RootPaths') #I resclasses package is not available. Check that the name is correct #I and it is present in one of the GAP root directories (see '??RootPaths') #I sophus package is not available. Check that the name is correct #I and it is present in one of the GAP root directories (see '??RootPaths') #I tomlib package is not available. Check that the name is correct #I and it is present in one of the GAP root directories (see '??RootPaths') Components: trans 1.0, prim 2.1, small* 1.0, id* 1.0 Packages: GAPDoc 1.6.2 Try '??help' for help. See also '?copyright', '?cite' and '?authors' gap> gap> gap> gap> gap> gap> gap> #I SmallGrp package is not available. To see further details, enter #I SetInfoLevel(InfoPackageLoading,4); and try to load the package again. fail gap> gap> > Error, no method found! For debugging hints type ?Recovery from NoMethodFound Error, no 1st choice method found for `+' on 2 arguments called from start + 1 at /usr/lib/gap/lib/test.gi:577 called from func( C[i] ) at /usr/lib/gap/lib/coll.gi:746 called from List( files, getStones ) at /usr/lib/gap/lib/test.gi:674 called from <function "TestDirectory">( <arguments> ) called from read-eval loop at line 10 of *stdin* you can 'quit;' to quit to outer loop, or you can 'return;' to continue brk> brk> FORCE_QUIT_GAP(1); # if we ever get here, there was an error error: Bad exit status from /var/tmp/rpm-tmp.Nt7ZJv (%check) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.Nt7ZJv (%check)
This one needs the gap, GAPDoc, gap-pkg-autodoc, and gap-pkg-io packages from the COPR repository to build successfully.
rpmbuild -ba gap-pkg-smallgrp.spec ... + /usr/lib/rpm/find-debuginfo.sh -j4 --strict-build-id -m -i --build-id-seed 1.3 -1.fc30 --unique-debug-suffix -1.3-1.fc30.x86_64 --unique-debug-src-base gap-pkg -smallgrp-1.3-1.fc30.x86_64 --run-dwz --dwz-low-mem-die-limit 10000000 --dwz-max -die-limit 110000000 -S debugsourcefiles.list /home/mufti/rpmbuild/BUILD/SmallGr p-1.3 find: 'debug': No such file or directory Maybe harmless...
$ rpmlint /home/mufti/rpmbuild/RPMS/noarch/gap-pkg-smallgrp-1.3-1.fc30.noarch.rpm ... gap-pkg-smallgrp.noarch: W: spurious-executable-perm /usr/lib/gap/pkg/SmallGrp-1.3/id10/idgrp10.g.gz gap-pkg-smallgrp.noarch: W: spurious-executable-perm /usr/lib/gap/pkg/SmallGrp-1.3/id9/idgrp9.g.gz
(In reply to J. Scheurich from comment #3) > find: 'debug': No such file or directory > > Maybe harmless... Yes, harmless. It's a noarch package, so there is no debug information. (In reply to J. Scheurich from comment #4) > $ rpmlint > /home/mufti/rpmbuild/RPMS/noarch/gap-pkg-smallgrp-1.3-1.fc30.noarch.rpm > ... > gap-pkg-smallgrp.noarch: W: spurious-executable-perm > /usr/lib/gap/pkg/SmallGrp-1.3/id10/idgrp10.g.gz > gap-pkg-smallgrp.noarch: W: spurious-executable-perm > /usr/lib/gap/pkg/SmallGrp-1.3/id9/idgrp9.g.gz Another good catch! I'll fix that tomorrow, too.
New URLs: Spec URL: https://jjames.fedorapeople.org/gap-pkg-smallgrp/gap-pkg-smallgrp.spec SRPM URL: https://jjames.fedorapeople.org/gap-pkg-smallgrp/gap-pkg-smallgrp-1.3-1.fc30.src.rpm
Let's try that again. New URLs: Spec URL: https://jjames.fedorapeople.org/gap-pkg-smallgrp/gap-pkg-smallgrp.spec SRPM URL: https://jjames.fedorapeople.org/gap-pkg-smallgrp/gap-pkg-smallgrp-1.3-2.fc30.src.rpm
fedora-review isn't working correctly at the moment for me, so I'm reviewing this package manually. Other than a minor typographical error (use of spaces on line 1, and tabs on line 4), this package is APPROVED. It conforms to the Fedora Packaging Guidelines, and is under an approved license. It builds cleanly in Rawhide.
Thank you for the review, Jared. How did that tab get in there? I will replace it with spaces prior to importing.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gap-pkg-smallgrp
Built in Rawhide.