Bug 1672896 - Review Request: perl-Applify - Write object oriented perl scripts with ease
Summary: Review Request: perl-Applify - Write object oriented perl scripts with ease
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-02-06 07:11 UTC by Emmanuel Seyman
Modified: 2019-02-07 16:53 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-02-07 16:53:27 UTC
Type: Bug
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Emmanuel Seyman 2019-02-06 07:11:17 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Applify/perl-Applify.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Applify/perl-Applify-0.15-1.fc29.src.rpm
Description:
This module should keep all the noise away and let you write scripts very
easily. These scripts can even be unit tested even though they are defined
directly in the script file and not in a module.

Fedora Account System Username: eseyman
Rpmlint Output: 1 packages and 1 specfiles checked; 0 errors, 0 warnings.

Comment 1 Jitka Plesnikova 2019-02-07 08:08:15 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires are almost ok
FIX: Please add BR 'make', it is used in spec file.

$ rpm -qp --requires perl-Applify-0.15-1.fc30.noarch.rpm | sort | uniq -c
      1 perl(Carp)
      1 perl(constant)
      1 perl(File::Basename)
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
FIX: Please add run-require 'perl(Getopt::Long)' - lib/Applify.pm:346

$ rpm -qp --provides perl-Applify-0.15-1.fc30.noarch.rpm | sort | uniq -c
      1 perl(Applify) = 0.15
      1 perl-Applify = 0.15-1.fc30
Binary provides are Ok.

$ rpmlint ./perl-Applify*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Please correct all 'FIX' issues.

Otherwise the package looks good.
Approved.

Comment 2 Emmanuel Seyman 2019-02-07 09:09:15 UTC
Thank you, Jikta. I've requested the repo and taken your comments into account.

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Applify/perl-Applify.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Applify/perl-Applify-0.15-2.fc29.src.rpm

Comment 3 Gwyn Ciesla 2019-02-07 14:33:57 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Applify

Comment 4 Emmanuel Seyman 2019-02-07 16:53:27 UTC
I've imported the package and an update is pending for F29.


Note You need to log in before you can comment on or make changes to this bug.