RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1672935 - fstab options are prefilled incorrectly in the "Filesystem Mounting" dialog
Summary: fstab options are prefilled incorrectly in the "Filesystem Mounting" dialog
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: cockpit-appstream
Version: ---
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: 8.1
Assignee: Marius Vollmer
QA Contact: Jan Ščotka
URL:
Whiteboard:
Depends On: 1678935
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-02-06 09:27 UTC by Marius Vollmer
Modified: 2020-11-14 10:13 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-11-05 20:41:39 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2019:3325 0 None None None 2019-11-05 20:41:48 UTC

Description Marius Vollmer 2019-02-06 09:27:42 UTC
Description of problem:

Cockpit trues to prefills the fstab mount options with appropriate values.  Currently this includes adding the "_netdev" option for iSCSI and NBD devices, and adding the workaround needed for filesystems on VDO volumes.

This prefilling works correctly when formatting a block device, but not when adding a filesystem to fstab later via the "Filesystem Mounting" dialog.  In that dialog, the options are prefilled, but they are computed as if they were for crypttab.

This makes a difference for VDO: the necessary workaround for filesystems on VDO volumes will not be prefilled.

Version-Release number of selected component (if applicable):
Cockpit 186 and earlier

How reproducible:
Always

Steps to Reproduce:
1. Create a VDO volume
2. Format it as xfs, say, with "Default" mounting
3. Open the "Filesystem Mounting" dialog and change to "Custom"

Actual results:
"Custom mount options" does not contains "x-systemd.requires=vdo.service"

Expected results:
"Custom mount options" does contains "x-systemd.requires=vdo.service"

Additional info:
Leaving out x-systemd.requires=vdo.service only makes a difference when the vdo.service unit is disabled.  When it is enabled, the _netdev option is enough to ensure proper ordering.  The vdo.service unit is enabled by default, so people will likely not run into any immediate trouble.

Comment 1 Martin Pitt 2019-02-12 20:28:05 UTC
Marius, is this fixed by https://github.com/cockpit-project/cockpit/commit/fc3703a1b1e7 ? Although that sounded like the opposite direction.

Comment 2 Marius Vollmer 2019-02-14 09:51:10 UTC
(In reply to Martin Pitt from comment #1)
> Marius, is this fixed by
> https://github.com/cockpit-project/cockpit/commit/fc3703a1b1e7 ? Although
> that sounded like the opposite direction.

That's the fix.

Comment 7 errata-xmlrpc 2019-11-05 20:41:39 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:3325


Note You need to log in before you can comment on or make changes to this bug.