Description of problem: [RFE] All Public Cloud Providers Load Balancer Inventory
https://github.com/ManageIQ/manageiq/pull/18918
https://github.com/ManageIQ/manageiq-ui-classic/pull/5754
Its a 2 part fix, core and UI sides. Both PRs above and should be merged at same time.
New commits detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/a48f4fcf81be1407d1ad00a02ebde8d8b82a7d6f commit a48f4fcf81be1407d1ad00a02ebde8d8b82a7d6f Author: Greg Piatigorski <gpiatigo> AuthorDate: Wed Jun 26 19:01:16 2019 -0400 Commit: Greg Piatigorski <gpiatigo> CommitDate: Wed Jun 26 19:01:16 2019 -0400 Remove Networks Load Balancer menu https://bugzilla.redhat.com/show_bug.cgi?id=1672949 db/fixtures/miq_product_features.yml | 29 - db/fixtures/miq_shortcuts.yml | 5 - db/fixtures/miq_user_roles.yml | 2 - lib/rbac/filterer.rb | 1 - locale/en.yml | 1 - spec/lib/rbac/filterer_spec.rb | 1 - 6 files changed, 39 deletions(-) https://github.com/ManageIQ/manageiq/commit/b28adef886cedf56ad60d84b652af4b00903ea28 commit b28adef886cedf56ad60d84b652af4b00903ea28 Author: Greg Piatigorski <gpiatigo> AuthorDate: Tue Jul 2 13:26:20 2019 -0400 Commit: Greg Piatigorski <gpiatigo> CommitDate: Tue Jul 2 13:26:20 2019 -0400 Remove deprecated Load Balancer from BelongsTo filter classes https://bugzilla.redhat.com/show_bug.cgi?id=1672949 lib/rbac/filterer.rb | 1 - 1 file changed, 1 deletion(-) https://github.com/ManageIQ/manageiq/commit/5eb9b41cb0104d923d3e5f77f4932afffb7b6b2c commit 5eb9b41cb0104d923d3e5f77f4932afffb7b6b2c Author: Greg Piatigorski <gpiatigo> AuthorDate: Tue Jul 2 14:56:30 2019 -0400 Commit: Greg Piatigorski <gpiatigo> CommitDate: Tue Jul 2 14:56:30 2019 -0400 Fixes misspelling of belongs to spec code https://bugzilla.redhat.com/show_bug.cgi?id=1672949 spec/lib/rbac/filterer_spec.rb | 6 +- 1 file changed, 3 insertions(+), 3 deletions(-)
New commits detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/e722a2de293e8041b12da21d7a1371173dd03d1f commit e722a2de293e8041b12da21d7a1371173dd03d1f Author: Greg Piatigorski <gpiatigo> AuthorDate: Thu Jun 27 11:59:26 2019 -0400 Commit: Greg Piatigorski <gpiatigo> CommitDate: Thu Jun 27 11:59:26 2019 -0400 Remove deprecated Networks Load Balancer menu https://bugzilla.redhat.com/show_bug.cgi?id=1672949 app/controllers/load_balancer_controller.rb | 36 - app/presenters/menu/default_menu.rb | 1 - app/views/load_balancer/show.html.haml | 5 - app/views/load_balancer/show_list.html.haml | 2 - 4 files changed, 44 deletions(-) https://github.com/ManageIQ/manageiq-ui-classic/commit/7e092885f03ee2d36d760f9e8a7f7c3b77f704f5 commit 7e092885f03ee2d36d760f9e8a7f7c3b77f704f5 Author: Greg Piatigorski <gpiatigo> AuthorDate: Fri Jun 28 13:26:29 2019 -0400 Commit: Greg Piatigorski <gpiatigo> CommitDate: Fri Jun 28 13:26:29 2019 -0400 Remove spec related code for deprecated Networks Load Balancer menu https://bugzilla.redhat.com/show_bug.cgi?id=1672949 spec/controllers/ems_network_controller_spec.rb | 3 +- spec/controllers/load_balancer_controller_spec.rb | 3 - spec/helpers/load_balancer_helper/textual_summary_spec.rb | 14 - spec/services/dialog_local_service_spec.rb | 7 - spec/shared/controllers/shared_examples_for_ems_network_controller.rb | 6 - spec/shared/controllers/shared_examples_for_load_balancer_controller.rb | 59 - spec/shared/controllers/shared_network_manager_context.rb | 22 - spec/views/layouts/listnav/_load_balancer.html.haml_spec.rb | 47 - 8 files changed, 1 insertion(+), 160 deletions(-) https://github.com/ManageIQ/manageiq-ui-classic/commit/a85334f8a94403496c7b38002de25fa9a0a97231 commit a85334f8a94403496c7b38002de25fa9a0a97231 Author: Greg Piatigorski <gpiatigo> AuthorDate: Mon Jul 1 21:28:48 2019 -0400 Commit: Greg Piatigorski <gpiatigo> CommitDate: Mon Jul 1 21:28:48 2019 -0400 Remove deprecated Load Balancer menu https://bugzilla.redhat.com/show_bug.cgi?id=1672949 app/helpers/application_helper/toolbar/load_balancer_center.rb | 17 - app/helpers/application_helper/toolbar/load_balancers_center.rb | 23 - app/helpers/load_balancer_helper.rb | 32 - app/helpers/load_balancer_helper/textual_summary.rb | 81 - spec/helpers/load_balancer_helper_spec.rb | 33 - 5 files changed, 186 deletions(-)
Verificaton failed in 5.11.0.14. I can still see Load Balancer in Network Manager and Instance relationships.
Created attachment 1590162 [details] Load balancer in instance details
Created attachment 1590163 [details] Load balancer in Network Manager details
https://github.com/ManageIQ/manageiq-ui-classic/pull/5821
New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/492069079ad16f6a255ffcaf509a0470560f280d commit 492069079ad16f6a255ffcaf509a0470560f280d Author: Greg Piatigorski <gpiatigo> AuthorDate: Tue Jul 16 18:04:49 2019 -0400 Commit: Greg Piatigorski <gpiatigo> CommitDate: Tue Jul 16 18:04:49 2019 -0400 Remove additional deprecated Load Balancers code in UI https://bugzilla.redhat.com/show_bug.cgi?id=1672949 app/controllers/mixins/ems_common.rb | 1 - app/controllers/vm_common.rb | 4 - app/helpers/application_helper/toolbar_chooser.rb | 2 +- app/helpers/ems_network_helper/textual_summary.rb | 6 +- app/helpers/vm_helper/textual_summary.rb | 15 +- app/services/network_topology_service.rb | 5 - config/routes.rb | 1 - spec/helpers/ems_network_helper/textual_summary_spec.rb | 1 - spec/helpers/vm_helper/textual_summary_spec.rb | 1 - 9 files changed, 3 insertions(+), 33 deletions(-)
Created attachment 1593432 [details] Load balancers button displayed in Network Topology Okay, it shouldn't be in Relationships anywhere but I found out there is still Loadbalancer Button in Networks Topology.
Removing Load balancer button from Network Topology display (UI).
https://github.com/ManageIQ/manageiq-ui-classic/pull/5918
New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/b4b830a9a97d2d20302d4dab2f14f7573f44fe9e commit b4b830a9a97d2d20302d4dab2f14f7573f44fe9e Author: Greg Piatigorski <gpiatigo> AuthorDate: Wed Jul 31 15:56:25 2019 -0400 Commit: Greg Piatigorski <gpiatigo> CommitDate: Wed Jul 31 15:56:25 2019 -0400 Remove Load Balancer button from Network Topology page https://bugzilla.redhat.com/show_bug.cgi?id=1672949 app/views/network_topology/show.html.haml | 4 - 1 file changed, 4 deletions(-)
New commit detected on ManageIQ/manageiq-ui-classic/ivanchuk: https://github.com/ManageIQ/manageiq-ui-classic/commit/d492b14a6c51201f592f6220610ad403ce78a999 commit d492b14a6c51201f592f6220610ad403ce78a999 Author: Harpreet Kataria <hkataria> AuthorDate: Thu Aug 1 15:54:34 2019 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Thu Aug 1 15:54:34 2019 -0400 Merge pull request #5918 from GregP/delete_network_topology_load_balancer_code Remove Load Balancer button from Network Topology page (cherry picked from commit ccb234f7636f629d0d740f3357068140030b45da) https://bugzilla.redhat.com/show_bug.cgi?id=1672949 app/views/network_topology/show.html.haml | 4 - config/routes.rb | 25 - 2 files changed, 29 deletions(-)
Verified in 5.10.0.18. There should be no places where Load Balancers are displayed.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:4199