RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1672957 - [RHEL 7.7] [libvirt] Backport 07c9d6601 ("qemu: use line breaks in command line args written to log")
Summary: [RHEL 7.7] [libvirt] Backport 07c9d6601 ("qemu: use line breaks in command li...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.7
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Daniel Berrangé
QA Contact: Yanqiu Zhang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-02-06 10:28 UTC by Kashyap Chamarthy
Modified: 2019-08-06 13:14 UTC (History)
6 users (show)

Fixed In Version: libvirt-4.5.0-18.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-08-06 13:14:35 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2019:2294 0 None None None 2019-08-06 13:14:52 UTC

Description Kashyap Chamarthy 2019-02-06 10:28:50 UTC
Please backport (or let it in via rebase) the following commit to RHEL 
7.7.  This makes debugging more pleasant (don't understimate how
important this is for those who look at giant QEMU command-lines without
any line breaks, all the time).  And, as DanPB noted on IRC, we'll now
be able to read the QEMU command-line when people copy / paste it in
bugs, without making our eyes bleed.

    commit 07c9d6601d0b440acd13794b258bdcb570ae93f4
    Author: Daniel P. Berrangé <berrange>
    Date:   Fri Dec 14 12:07:08 2018 +0000

        qemu: use line breaks in command line args written to log
    
        The QEMU command line arguments are very long and currently all written
        on a single line to /var/log/libvirt/qemu/$GUEST.log. This introduces
        logic to add line breaks after every env variable and "-" optional
        argument, and every positional argument. This will create a clearer log
        file, which will in turn present better in bug reports when people cut +
        paste from the log into a bug comment.
    
        An example log file entry now looks like this:
    
          2018-12-14 12:57:03.677+0000: starting up libvirt version: 5.0.0, qemu version: 3.0.0qemu-3.0.0-1.fc29, kernel: 4.19.5-300.fc29.x86_64, hostname: localhost.localdomain
          LC_ALL=C \
          PATH=/usr/local/bin:/usr/local/sbin:/usr/bin:/usr/sbin \
          HOME=/home/berrange \
          USER=berrange \
          LOGNAME=berrange \
          QEMU_AUDIO_DRV=none \
          /usr/bin/qemu-system-ppc64 \
          -name guest=guest,debug-threads=on \
          -S \
          -object secret,id=masterKey0,format=raw,file=/home/berrange/.config/libvirt/qemu/lib/domain-33-guest/master-key.aes \
          -machine pseries-2.10,accel=tcg,usb=off,dump-guest-core=off \
          -m 1024 \
          -realtime mlock=off \
          -smp 1,sockets=1,cores=1,threads=1 \
          -uuid c8a74977-ab18-41d0-ae3b-4041c7fffbcd \
          -display none \
          -no-user-config \
          -nodefaults \
          -chardev socket,id=charmonitor,fd=23,server,nowait \
          -mon chardev=charmonitor,id=monitor,mode=control \
          -rtc base=utc \
          -no-shutdown \
          -boot strict=on \
          -device qemu-xhci,id=usb,bus=pci.0,addr=0x1 \
          -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x2 \
          -sandbox on,obsolete=deny,elevateprivileges=deny,spawn=deny,resourcecontrol=deny \
          -msg timestamp=on
          2018-12-14 12:57:03.730+0000: shutting down, reason=failed

        Signed-off-by: Daniel P. Berrangé <berrange>

Comment 2 RHEL Program Management 2019-04-03 12:13:54 UTC
Development Management has reviewed and declined this request. You may appeal this decision by reopening this request.

Comment 3 Daniel Berrangé 2019-04-03 12:26:46 UTC
Re-opening this because it will make our life as maintainers much less painful to have this more intelligible command line args in bug reports users/customers file.

Comment 8 errata-xmlrpc 2019-08-06 13:14:35 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:2294


Note You need to log in before you can comment on or make changes to this bug.