Bug 1673106 - [RFE] Restrict floppy device to RHEL-7 machine types
Summary: [RFE] Restrict floppy device to RHEL-7 machine types
Keywords:
Status: CLOSED EOL
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: openstack-nova
Version: 17.0 (Wallaby)
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: ---
: ---
Assignee: OSP DFG:Compute
QA Contact: OSP DFG:Compute
URL:
Whiteboard:
Depends On: 1664997
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-02-06 17:10 UTC by Erwan Gallen
Modified: 2023-03-21 19:11 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1664997
Environment:
Last Closed: 2020-11-04 19:52:20 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Erwan Gallen 2019-02-06 17:10:34 UTC
+++ This bug was initially created as a clone of Bug #1664997 +++

Description of problem:
It's 2018, and we still provide a virtual floppy device for new virtual machines we intend to support for many, many years.

Maintaining the floppy device model in qemu-kvm has been expensive.  After VENOM (CVE-2015-3456), upstream suppressed the floppy controller for modern machine types by default (commit ea96bc629cb), because "It is Very annoying to carry forward an outdatEd coNtroller with a mOdern Machine type."  Users can still get floppy devices, but they have to ask for them.  This is a compromise that makes sense for upstream.

We tried to get rid of floppies in RHEL-7 (released in 2014), but ultimately failed, because RHEV could not move its Windows setup method from floppies to CD-ROMs in time.  If we had succeeded, we would've spared significant work and also embarrassment.

For backward compatibility, we need to continue to support floppies with RHEL-7 machine types.  However, supporting them with new machines makes no sense at all.

Version-Release number of selected component (if applicable):
qemu-kvm-3.1.0-3.el8

How reproducible:
Always

Steps to Reproduce:
1. Run qemu-kvm with RHEL-8 machine type:
$ qemu-kvm -nodefaults -display none -S -M pc-q35-rhel8.0.0 -monitor stdio -device isa-fdc
2. Check devices:
(qemu) info qtree

Actual results:
There is an isa-fdc device:
        bus: isa.0
          type ISA
          dev: isa-fdc, id ""

Expected results:
-device isa-fdc is rejected in step 1.

Alternate reproducer: replace -device isa-fdc by -drive if=floppy.

Additional info:
The isa-fdc device gets created when the user asks for it explicitly with -device isa-fdc or implicitly with -drive if=floppy.

The explicit way is pretty useless actually, because it creates only the floppy controller, and there is no way to connect floppy drives to it (commit 0533a6ee98f makes device "floppy" unavailable with -device).

--- Additional comment from Martin Tessun on 2019-02-05 13:51:05 UTC ---

I believe floppies are currently used for the following tasks:
- Windows driver disks
- Windows sysprep information
- cloud-init data
- Kickstart information for RHEL

I believe all of these usecases could be replaced by an ISO instead.
@Michal: Do you agree? If we do this, we will need to change RHV 4.4 once we use RHEL8 based machine types. This would also remove the ISA driver from qemu completely.
@Erwan: Does RHOSP use floppies at all?

Comment 1 Erwan Gallen 2019-02-07 14:50:16 UTC
Upstream OpenStack thread started by Kashyap:
[nova] Floppy drive support — does anyone rely on it?
http://lists.openstack.org/pipermail/openstack-discuss/2019-February/002479.html

Blueprint:
https://blueprints.launchpad.net/nova/+spec/remove-support-for-floppy-disks

Comment 4 stchen 2020-11-04 19:52:20 UTC
Closing EOL, OSP 16.0 has been retired as of Oct 27, 2020


Note You need to log in before you can comment on or make changes to this bug.