Bug 1673277 - "Volume Option cluster.granular-entry-heal=enable could not be set" when using "Optimize for Virt store"
Summary: "Volume Option cluster.granular-entry-heal=enable could not be set" when usin...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: vdsm
Classification: oVirt
Component: Gluster
Version: 4.30.0
Hardware: x86_64
OS: Linux
high
high
Target Milestone: ovirt-4.4.0
: 4.40.5
Assignee: Kaustav Majumder
QA Contact: SATHEESARAN
URL:
Whiteboard:
Depends On:
Blocks: 1693187
TreeView+ depends on / blocked
 
Reported: 2019-02-07 08:35 UTC by Netbulae
Modified: 2020-08-05 06:10 UTC (History)
7 users (show)

Fixed In Version: vdsm-4.40.5
Clone Of:
: 1693187 (view as bug list)
Environment:
Last Closed: 2020-08-05 06:10:11 UTC
oVirt Team: Gluster
Embargoed:
sasundar: ovirt-4.4?
sbonazzo: planning_ack?
godas: devel_ack+
sasundar: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 98939 0 'None' ABANDONED gluster: Added verb for setting cluster.granular-entry-heal 2020-12-23 16:36:37 UTC
oVirt gerrit 98941 0 'None' MERGED gluster: Enable setting of volume option 'cluster.granular-entry-heal' 2020-12-23 16:36:05 UTC
oVirt gerrit 102582 0 'None' MERGED gluster: Enable setting of volume option 'cluster.granular-entry-heal' 2020-12-23 16:36:01 UTC
oVirt gerrit 103508 0 'None' MERGED gluster: Enable setting of volume option 'cluster.granular-entry-heal' 2020-12-23 16:36:35 UTC
oVirt gerrit 104071 0 ovirt-4.3 ABANDONED gluster: Enable setting of volume option 'cluster.granular-entry-heal' 2020-12-23 16:36:03 UTC
oVirt gerrit 104094 0 'None' MERGED gluster: Fix errors related to patch https://gerrit.ovirt.org/#/c/103508/ 2020-12-23 16:36:03 UTC
oVirt gerrit 105919 0 master MERGED gluster: Fix for setting volume options in states {CREATED,STARTED,STOP} 2020-12-23 16:36:01 UTC

Description Netbulae 2019-02-07 08:35:24 UTC
When I use "Optimize for Virt store" on one of our newly created storage volumes, I get one option that failed: 

2019-02-06 10:25:02,353+01 ERROR [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (EE-ManagedThreadFactory-engine-Thread-15727) [051cfc8c-9efc-427c-9e2e-9127e3e0a86d] EVENT_ID: GLUSTER_VOLUME_OPTION_SET_FAILED(4,003), Volume Option cluster.granular-entry-heal=enable could not be set on ssd9 of cluster GlusterFS-storage.


This looks like the same issue as https://bugzilla.redhat.com/show_bug.cgi?id=1635684

    Volume set option 'granular-entry-heal' is not longer set via gluster volume set option.

When the option is already set, it reports ok.

Comment 1 Sahina Bose 2019-05-07 13:56:10 UTC
Kaustav, any update on patches?

Comment 2 Kaustav Majumder 2019-06-03 07:26:50 UTC
Two patches posted with different approaches. Kindly suggest one to go further.

Comment 3 SATHEESARAN 2019-07-18 17:38:34 UTC
As confirmed with Gobinda, this fix for this bug will targeted for RHV 4.3.6

Comment 4 SATHEESARAN 2019-09-04 01:18:07 UTC
Tested with vdsm-4.30.29

Still hit the problem, looks like the code path still uses 'volume set'.


The behavior as observed:
1. When volume is just created, 'optimize for virt-store' works
2. When the volume is started, 'optimize for virt-store' fails.


Expectation:
At any stage of volume: created, started, or stopped, volume set operation should not throw any error
In this case, it fails for 'granular-entry-heal'


Information
Replica 3 volume when set with 'granular-entry-heal' during 'optimize for virtstore',
should do check for some conditions:

1. When the volume is just created, use 'gluster volume set' to be used
2. Once the volume is in stopped or started state, 'gluster volume heal' command to be used

Comment 5 SATHEESARAN 2019-09-04 07:30:16 UTC
This bug needs fix that will be addressed with patch from Kaustav. ( As we discussed in Google chat platform )
This bug is not a blocker as all the volume options are set through gluster-ansible for deployment.
This issue affects only the customers that try to optimize volume ( that is already started ) for virt store from RHV Manager UI.

Considering this, the impact/severity is low in this case
Re-targeting this bug for RHV 4.3.7

Comment 7 Kaustav Majumder 2019-10-16 11:55:29 UTC
Hi,
Yes can be moved to 4.4.

Comment 8 Sandro Bonazzola 2019-12-19 09:03:13 UTC
So can you abandon https://gerrit.ovirt.org/#/c/104071/ ?

Comment 9 Kaustav Majumder 2019-12-19 09:05:30 UTC
Done

Comment 10 SATHEESARAN 2020-06-17 03:03:12 UTC
Tested with RHV Manager 4.4.1.2-0.10.el8ev and vdsm-4.40.20-1.el8ev.x86_64

1. When volume is just created, 'optimize for vmstore' from RHV Manager Admin portal enables granular-entry-heal
2. When volume is started once, 'optimize for vmstore' from RHV Manager Admin portal fails to set granular-entry-heal,
but the value is set with 'gluster volume heal' command

Comment 11 Sandro Bonazzola 2020-08-05 06:10:11 UTC
This bugzilla is included in oVirt 4.4.0 release, published on May 20th 2020.

Since the problem described in this bug report should be
resolved in oVirt 4.4.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.