Spec Name or Url: http://www.all-the-johnsons.co.uk/emulators/downloads/fuse-utils-0.7.0.spec SRPM Name or Url: http://www.all-the-johnsons.co.uk/emulators/downloads/fuse-utils-0.7.0.src.rpm Description: Fuse utils are 10 small command line programs for use with the FUSE ZX Spectrum emulator software
No review, just a note: FUSE (file System in userspace, fuse.sf.net) is currently heading for inclusion in the upstream kernel (at least they try very hard afaics). That FUSE also has a userland part that is named "utils" in the src-pgk -- so a resulting package for fedora-extras/core might be (you guessed it) fuse-utils. I think this fuse might be more popular in the future (or already is) than the emulator fuse. Therefore IMHO you should rename your pgk to fuseemu-utils oder fuse-spectrum-utils (or something like that) to avoid user confusion (even if there is no fuse-the-filesystem-pgk in Core/Extras yet). BTW: can't find anything below http://www.all-the-johnsons.co.uk/emulators/*
Sorry, yes, you're right about the name, it should be fuse-emulator-utils. I'll correct that.
None of the URLs in this bug appear to work.
Spec Name or Url: http://www.all-the-johnsons.co.uk/emulation/downloads/fuse-utils-0.7.0.spec SRPM Name or Url: http://www.all-the-johnsons.co.uk/emulation/downloads/fuse-utils-0.7.0-1.src.rpm Sorry for the delay, events have over taken me...
Please also provide new URLs for related Bug 166960.
/me completely confused -- this package was imported to cvs, the bug closed, but I can't see a "approved" anywhere here. Did I miss anything? Only libspectrum, lib765 and libdsk from Bug 17180 got and approved afaics. And Paul, why didn't you rename it to fuse-emulator-utils as you said yourself in comment #2 to avoid confusion with Fuse, the "Filesystem in Userspace"? Yes, it has no "fuse-uils" subpackage, but that could change in the future. And it's confusing anyway -- fuse-emulator-utils would be the better name imho.
D'oh! For some reason, I thought that it had been approved. I'll remove it from cvs when I get home.
(In reply to comment #7) > D'oh! For some reason, I thought that it had been approved. You probably should reopen Bug 166960 , too. I'll repair the damage which you have done to fuse (the filesystem) myself. > I'll remove it from cvs when I get home. Don't know if it's that easy. Might be the best if you ask for removal on http://www.fedoraproject.org/wiki/Extras/CVSSyncNeeded
Spec Name or Url: http://www.smmp.salford.ac.uk/packages/fuse-emulator-utils-0.7.0.spec I've not rebuilt it as there is a blocker against 64 bit architectures - I'll need to investigate that on the source
Ping : anyone want to review and approve this?
Well, I would except 1) The link to the spec file doesnt work 2) I still cant assign myself to bugs yet 3) I am on a 64bit architecture
Spec Name or Url: http://www.smmp.salford.ac.uk/packages/fuse-emulator-utils.spec I can't comment on (2), but it should be fine with 64 bit, afterall, that's what I'm using!
Can someone please review this for accepting into extras?
Created attachment 128201 [details] Fix first pass issues with spec First pass items: * URL should be: http://fuse-emulator.sourceforge.net/ * Source0 should be: http://dl.sf.net/fuse-emulator/fuse-utils-%{version}.tar.gz * Can't check that sources match upstream because no current SRPM URL posted * No comment explaining need for ExcludeArch * Description has "Fuse-emulation-utils " rather than "fuse-emulator-utils" * %setup needs -n fuse-utils-%{version} * Binaries are all installed mode 644 so they can't be executed - Easier just to use "make DESTDIR=${RPM_BUILD_ROOT} install" * Please include ChangeLog as %doc * Package shouldn't own %{_bindir} * Add "chmod 644 createhdf.c" in %prep to fix rpmlint warning for debuginfo pkg Please ensure that your packages actually build (preferably in mock) before submitting them.
Spec Name or Url: http://www.all-the-johnsons.co.uk/emulation/downloads/fuse-utils-0.7.0.spec SRPM Name or Url: http://www.all-the-johnsons.co.uk/emulation/downloads/fuse-utils-0.7.0-4.src.rpm All points in #14 addressed. ExcludeArch removed
http://www.all-the-johnsons.co.uk/emulation/downloads/fuse-utils-0.7.0-4.src.rpm 404 Not Found The requested URL /emulation/downloads/fuse-utils-0.7.0-4.src.rpm was not found on this server. I hope the spec file inside the SRPM is called fuse-emulator-utils.spec but I suspect it won't be given the SRPM name. Please fix this before posting the next URL.
Spec Name or Url: http://www.knox.net.nz/~nodoid/fuse-emulator-utils-0.7.0.spec SRPM Name or Url: http://www.knox.net.nz/~nodoid/fuse-emulator-utils-0.7.0-4.src.rpm D'oh! The spec file has been fixed as you've suggested.
Review of fuse-emulator-utils-0.7.0-4 ------------------------------------- - rpmlint clean - package and spec naming OK - package meets guidelines - package is GPL, matches spec, text included - spec file written in English and is legible - sources match upstream - package builds OK in mock with reduced package list on rawhide (i386) - buildreqs OK - no locales, libraries, pkgconfig files, or subpackages to worry about - not relocatable - no directory ownership or permissions issues - no duplicate files - %clean section present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime - not a GUI package, no desktop file needed - no scriptlets Needswork: - %description still refers to "Fuse-emulation-utils " rather than "fuse-emulator-utils"; please add a full stop at the end of the description too. You can fix this in cvs if you prefer. Approved.
Normalize summary field for easy parsing Unless I'm mistaken, this should block FE-ACCEPT rather than FC-ACCEPT (fixed)
Package Change Request ====================== Package Name: fuse-emulator-utils Updated Fedora Owners: packages,paul.uk The current maintainer (paul.uk) has given me his permission to take ownership of this package as he is unable to maintain it at the moment for personal reasons. I would like Paul to remain as co-maintainer in case he wishes to continue with the package in the future.
cvs done.