Bug 1674742 - Custom Properties silently removed when changing VM cluster
Summary: Custom Properties silently removed when changing VM cluster
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.3.0
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ovirt-4.4.8
: 4.4.8.4
Assignee: Lucia Jelinkova
QA Contact: Ivana Saranova
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-02-11 16:57 UTC by Ryan
Modified: 2021-09-03 10:07 UTC (History)
4 users (show)

Fixed In Version: ovirt-engine-4.4.8.4
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-09-03 10:07:07 UTC
oVirt Team: Virt
Embargoed:
pm-rhel: ovirt-4.4+
gdeolive: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 115956 0 master MERGED webadmin: preserve custom properties on cluster change 2021-08-10 16:04:24 UTC

Description Ryan 2019-02-11 16:57:40 UTC
Description of problem:
When you change a VMs cluster it loses all its custom properties

Version-Release number of selected component (if applicable):
4.3

How reproducible:
Easy

Steps to Reproduce:
1. Create a VM with custom properties (in our case hugepages)
2. Edit the VM and change its cluster

Actual results:
Custom Properties are silently removed

Expected results:
Custom Properties are retained.


Additional info:
Ran into this when upgrading to 4.3. Since we had to upgrade the CPU type we decided to make a new 4.3 cluster and just restart VMs into it to minimize downtime. One of our VMs uses a large amount of memory and is configured to use huge pages. When restarted it caused swapping on the host because the host did not have enough 'free' memory, even though it had plenty of hugepages available.

Not sure if it affects earlier version.

Maybe block the change if the destination cluster lacks support for a custom property?

The silent part is what makes this really unfortunate.

Comment 1 Ryan 2019-02-12 22:50:42 UTC
Just discovered that the 'Hardware Clock Time Offset' is also reset when changing clusters (Windows wasn't happy).

Not sure what other settings get reset on a cluster change, but seems to be more than just custom properties.

Comment 2 Ivana Saranova 2021-08-19 10:47:48 UTC
Steps:
1) Have a running VM with some custom settings and other various settings (hugepages, clock offset, console settings, icon,...)
2) Shutdown VM
3) Edit VM and change cluster and save
4) Check VM settings that all the previously set settings are still valid

Results:
No settings were changed after cluster change.

Verified in:
ovirt-engine-4.4.8.4-0.7.el8ev.noarch


Note You need to log in before you can comment on or make changes to this bug.