Description of problem: There seems to be perf regression of around 30% in mkdir path with patch : https://review.gluster.org/#/c/glusterfs/+/21062/. Here is the result from gbench which runs smallfile tool internally. Without patch: 3187.402238 2544.658604 2400.662029 (mkdir per second) With patch: 2439.311086 1654.222631 1634.522184 (mkdir per second) This bug is created to address the revert of the above commit. Version-Release number of selected component (if applicable): How reproducible: Always Steps to Reproduce: Run gbench
Update: After taking statedumps, io-threads xlator showed differences in latency. And here is the responsible code path. <<<< int iot_schedule (call_frame_t *frame, xlator_t *this, call_stub_t *stub) { int ret = -1; iot_pri_t pri = IOT_PRI_MAX - 1; iot_conf_t *conf = this->private; if ((frame->root->pid < GF_CLIENT_PID_MAX) && conf->least_priority) { pri = IOT_PRI_LEAST; goto out; } >>>> It seems requests with -ve pid gets the least priority. After testing with performance.enable-least-priority to be off, the results are normalized now. Here is the summary. Numbers are in files/sec Post with performance.enable-least-priority on: 5448.965051804044, 5382.812519425897, 5358.221152245441, Post with performance.enable-least-priority off: 6589.996990998271, 6458.350431426266, 6568.009725869085 Pre: 6387.711992865287, 6412.12706152037, 6570.547263693283 Will send a patch to prioritize ops with no-root-squash pid. Susant
REVIEW: https://review.gluster.org/22304 (io-threads: Prioritize fops with NO_ROOT_SQUASH pid) posted (#2) for review on release-6 by Susant Palai
REVIEW: https://review.gluster.org/22304 (io-threads: Prioritize fops with NO_ROOT_SQUASH pid) merged (#2) on release-6 by Susant Palai
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-6.0, please open a new bug report. glusterfs-6.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] https://lists.gluster.org/pipermail/announce/2019-March/000120.html [2] https://www.gluster.org/pipermail/gluster-users/